Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 10968027: Fix Android build breaks (Closed)

Created:
8 years, 3 months ago by jackpal
Modified:
8 years, 3 months ago
Reviewers:
siva, cshapiro
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix Android build breaks Prevent Android's STLPort from undefining global functions from math.h when cmath is included after math.h. The Android STLPort does not provide std::assert or std::atexit. Use the C versions of these functions on Android. BUG= Committed: https://code.google.com/p/dart/source/detail?r=12741

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use c library functions on all platforms rather than just on Android. #

Total comments: 1

Patch Set 3 : Remove unused #include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
D runtime/platform/assert.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M tools/gyp/configurations_android.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jackpal
Small tweaks to fix the Android build.
8 years, 3 months ago (2012-09-21 02:55:38 UTC) #1
cshapiro
http://codereview.chromium.org/10968027/diff/1/runtime/platform/assert.cc File runtime/platform/assert.cc (left): http://codereview.chromium.org/10968027/diff/1/runtime/platform/assert.cc#oldcode7 runtime/platform/assert.cc:7: #include <cstdlib> I think the only reason to use ...
8 years, 3 months ago (2012-09-21 03:14:54 UTC) #2
jackpal
On 2012/09/21 03:14:54, cshapiro wrote: > Can't we do a lot less in this CL ...
8 years, 3 months ago (2012-09-21 03:55:36 UTC) #3
cshapiro
8 years, 3 months ago (2012-09-21 20:27:42 UTC) #4
lgtm with comments

http://codereview.chromium.org/10968027/diff/4001/runtime/platform/assert.cc
File runtime/platform/assert.cc (right):

http://codereview.chromium.org/10968027/diff/4001/runtime/platform/assert.cc#...
runtime/platform/assert.cc:7: #include <cstdlib>
Please remove this line.

Powered by Google App Engine
This is Rietveld 408576698