Issue 10967044: Fix the types used in bit fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10967044: Fix the types used in bit fields. (Closed)

Created:
8 years, 3 months ago by siva

Modified:
8 years, 3 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Fix the types used in bit fields and a few other places. Committed: https://code.google.com/p/dart/source/detail?r=12820

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -65 lines)			Patch
M	vm/compiler_stats.cc	View	1	1 chunk	+15 lines, -13 lines	0 comments	Download
M	vm/memory_region.h	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	vm/object.h	View	1	4 chunks	+7 lines, -10 lines	0 comments	Download
M	vm/object.cc	View	1	5 chunks	+21 lines, -29 lines	0 comments	Download
M	vm/raw_object_snapshot.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	vm/snapshot.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

cshapiro

lgtm have you tried building with -Wconversion to see if this change makes the various ...

8 years, 3 months ago (2012-09-21 20:31:49 UTC) #2

siva

PTAL. Ran with -wno-conversions and fixed some of them. There are some more which I ...

8 years, 3 months ago (2012-09-24 22:14:22 UTC) #3

still lgtm - thanks