Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1825)

Unified Diff: vm/raw_object_snapshot.cc

Issue 10967044: Fix the types used in bit fields. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/object.cc ('k') | vm/snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/raw_object_snapshot.cc
===================================================================
--- vm/raw_object_snapshot.cc (revision 12729)
+++ vm/raw_object_snapshot.cc (working copy)
@@ -536,7 +536,7 @@
func.set_num_fixed_parameters(reader->ReadIntptrValue());
func.set_num_optional_parameters(reader->ReadIntptrValue());
func.set_deoptimization_counter(reader->ReadIntptrValue());
- func.set_kind_tag(reader->ReadIntptrValue());
+ func.set_kind_tag(reader->Read<uint16_t>());
// Set all the object fields.
// TODO(5411462): Need to assert No GC can happen here, even though
@@ -571,7 +571,7 @@
writer->WriteIntptrValue(ptr()->num_fixed_parameters_);
writer->WriteIntptrValue(ptr()->num_optional_parameters_);
writer->WriteIntptrValue(ptr()->deoptimization_counter_);
- writer->WriteIntptrValue(ptr()->kind_tag_);
+ writer->Write<uint16_t>(ptr()->kind_tag_);
// Write out all the object pointer fields.
SnapshotWriterVisitor visitor(writer);
@@ -626,7 +626,7 @@
// Write out all the non object fields.
writer->WriteIntptrValue(ptr()->token_pos_);
- writer->WriteIntptrValue(ptr()->kind_bits_);
+ writer->Write<uint8_t>(ptr()->kind_bits_);
// Write out all the object pointer fields.
SnapshotWriterVisitor visitor(writer);
« no previous file with comments | « vm/object.cc ('k') | vm/snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698