Use the VM under test, not the prebuilt binary

Use the VM under test, not the prebuilt binary

Committed: https://code.google.com/p/dart/source/detail?r=12760

[ricow1, 2012-09-24 07:42:57]

DBC

https://codereview.chromium.org/10965060/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/10965060/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:685: // As a special case, a command of
"dart" should run with the same
This comment seems outdated with this change

[Mads Ager (google), 2012-09-24 07:43:06]

LGTM, thanks Peter!

[Mads Ager (google), 2012-09-24 07:43:49]

https://codereview.chromium.org/10965060/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/10965060/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:685: // As a special case, a command of
"dart" should run with the same
On 2012/09/24 07:42:57, ricow1 wrote:
> This comment seems outdated with this change

it should be 'that we are testing'.

[ahe, 2012-09-24 08:31:22]

Thank you!

https://codereview.chromium.org/10965060/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/10965060/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:685: // As a special case, a command of
"dart" should run with the same
On 2012/09/24 07:42:57, ricow1 wrote:
> This comment seems outdated with this change

Done.

https://codereview.chromium.org/10965060/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:685: // As a special case, a command of
"dart" should run with the same
On 2012/09/24 07:43:49, Mads Ager wrote:
> On 2012/09/24 07:42:57, ricow1 wrote:
> > This comment seems outdated with this change
> 
> it should be 'that we are testing'.

Done.

[William Hesse, 2012-09-24 09:36:47]

The intent of this is to start a simple HTTP server in support of browser tests
of internationalization, not in support of VM tests.  The tests using this are
skipped in VM configurations.  So they fully intended to use the checked-in
binary, not the built VM.  In fact, these tests should even run when the VM is
not built at all, or failing.

The HTTP server they are starting is part of the test infrastructure, not part
of what is being tested.  So I expect you will see some pushback on this change.

[ahe, 2012-09-24 09:48:15]

On 2012/09/24 09:36:47, William Hesse wrote:
> The intent of this is to start a simple HTTP server in support of browser
tests
> of internationalization, not in support of VM tests.  The tests using this are
> skipped in VM configurations.  So they fully intended to use the checked-in
> binary, not the built VM.  In fact, these tests should even run when the VM is
> not built at all, or failing.
> 
> The HTTP server they are starting is part of the test infrastructure, not part
> of what is being tested.  So I expect you will see some pushback on this
change.

The HTTP server is in pkg/intl/test/start_web_server.dart. So it will most
likely use the latest API, not the slightly out-of-date that is bundled with
.../dart/tools/testing/bin/$OS/dart.

If the HTTP server is really part of the test frame work, it should be moved to
.../dart/tools/testing/dart and there shouldn't be a general mechanism for
running a Dart program during testing.

[Alan Knight, 2012-09-24 19:16:11]

On 2012/09/24 09:48:15, ahe wrote:
> On 2012/09/24 09:36:47, William Hesse wrote:
> > The intent of this is to start a simple HTTP server in support of browser
> tests
> > of internationalization, not in support of VM tests.  The tests using this
are
> > skipped in VM configurations.  So they fully intended to use the checked-in
> > binary, not the built VM.  In fact, these tests should even run when the VM
is
> > not built at all, or failing.
> > 
> > The HTTP server they are starting is part of the test infrastructure, not
part
> > of what is being tested.  So I expect you will see some pushback on this
> change.
> 
> The HTTP server is in pkg/intl/test/start_web_server.dart. So it will most
> likely use the latest API, not the slightly out-of-date that is bundled with
> .../dart/tools/testing/bin/$OS/dart.
> 
> If the HTTP server is really part of the test frame work, it should be moved
to
> .../dart/tools/testing/dart and there shouldn't be a general mechanism for
> running a Dart program during testing.

The intent is for it to be used as a tool to test something else, and there
isn't any attempt to verify the HTTP server itself. It is just copied from one
of our web site examples and very slightly modified. It might make more sense
for it to be considered part of the test framework, though I think it might want
to be generalized for such usage.