Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 10965060: Use the VM under test, not the prebuilt binary (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_suite.dart
diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart
index 15874b00be1184a576992319b8e551e416d82a12..a935b2c5ee05d2eb5674af94b35f789d619cf575 100644
--- a/dart/tools/testing/dart/test_suite.dart
+++ b/dart/tools/testing/dart/test_suite.dart
@@ -682,10 +682,10 @@ class StandardTestSuite implements TestSuite {
var extraCommand = optionsFromFile['extraCommand'];
if (extraCommand != null) {
var args = optionsFromFile['extraCommandArgs'];
- // As a special case, a command of "dart" should run with the same
- // dart executable that we are using.
+ // As a special case, a command of "dart" should run with the
+ // dart VM that we are testing.
if (extraCommand == 'dart') {
- extraCommand = new Options().executable;
+ extraCommand = TestUtils.vmFileName(configuration),
}
args= args.map((arg)=>arg.replaceAll(@"$dartDir", dartDir.toString()));
commands.add(new Command(extraCommand, args));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698