Issue 1096433003: Fix List length size check; add test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1096433003: Fix List length size check; add test. (Closed)

Created:
5 years, 8 months ago by koda

Modified:
5 years, 8 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix List length size check; add test. Ensures that we throw an exception rather than exit the VM (FATAL). BUG=dart:23227 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45223

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
	M	runtime/vm/code_generator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/object_test.cc	View		1 chunk	+21 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

Committed patchset #3 (id:40001) manually as r45223 (presubmit successful).

5 years, 8 months ago (2015-04-17 00:34:51 UTC) #3

Ivan Posva

5 years, 8 months ago (2015-04-17 04:38:25 UTC) #5

Message was sent while issue was closed.

DBC -ip

https://codereview.chromium.org/1096433003/diff/40001/runtime/vm/object_test.cc
File runtime/vm/object_test.cc (right):

https://codereview.chromium.org/1096433003/diff/40001/runtime/vm/object_test....
runtime/vm/object_test.cc:1955: const intptr_t kLength = Array::kMaxElements +
1;
Please verify that this test passes with kMaxElements. And that it also fails
with negative values.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages