Fix List length size check; add test.

runtime/vm/object_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 
 #include "vm/assembler.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
@@ skipping 1933 matching lines @@
   EXPECT_EQ(1, Object::zero_array().Length());
   element = Object::zero_array().At(0);
   EXPECT(Smi::Cast(element).IsZero());
 
   array.MakeImmutable();
   Object& obj = Object::Handle(array.raw());
   EXPECT(obj.IsArray());
 }
 
 
+TEST_CASE(ArrayLength) {
+  const intptr_t kLength = Array::kMaxElements + 1;

[Ivan Posva, 2015/04/17 04:38:25]

Please verify that this test passes with kMaxElements. And that it also fails
with negative values.

+  ASSERT(kLength >= 0);
+  char buffer[1024];
+  OS::SNPrint(buffer, sizeof(buffer),
+      "main() {\n"
+      "  new List(%" Pd ");\n"
+      "}\n",
+      kLength);
+  Dart_Handle lib = TestCase::LoadTestScript(buffer, NULL);
+  EXPECT_VALID(lib);
+  Dart_Handle result = Dart_Invoke(lib, NewString("main"), 0, NULL);
+  OS::SNPrint(buffer, sizeof(buffer),
+      "Unhandled exception:\n"
+      "Invalid argument(s): Length (%" Pd ") must be an integer "
+      "in the range [0..%" Pd "].",
+      kLength, Array::kMaxElements);
+  EXPECT_ERROR(result, buffer);
+}
+
+
 TEST_CASE(StringCodePointIterator) {
   const String& str0 = String::Handle(String::New(""));
   String::CodePointIterator it0(str0);
   EXPECT(!it0.Next());
 
   const String& str1 = String::Handle(String::New(" \xc3\xa7 "));
   String::CodePointIterator it1(str1);
   EXPECT(it1.Next());
   EXPECT_EQ(' ', it1.Current());
   EXPECT(it1.Next());
@@ skipping 2511 matching lines @@
   EXPECT_VALID(h_result);
   Integer& result = Integer::Handle();
   result ^= Api::UnwrapHandle(h_result);
   String& foo = String::Handle(String::New("foo"));
   Integer& expected = Integer::Handle();
   expected ^= foo.HashCode();
   EXPECT(result.IsIdenticalTo(expected));
 }
 
 }  // namespace dart