Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 10963009: Fix implicit super constructor calls for sub-classes of native field wrappers. (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)
Modified:
8 years, 3 months ago
Reviewers:
siva, hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix implicit super constructor calls for sub-classes of native field wrappers. The current code does not add implicit super calls for any sub-classes of native field wrappers. It should only omit them from the actual native field wrappers. I encountered this issue when looking into dartbug.com/5301. The test in the parser is not pretty. However, since the native field wrappers can be generated through the API a better solution was not immediate. I wanted to check if the class was from the dart:nativewrappers library, but through the API you can create native wrappers in any other library as well. R=hausner@google.com,asiva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M runtime/vm/dart_api_impl_test.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 3 months ago (2012-09-20 13:20:45 UTC) #1
hausner
lgtm
8 years, 3 months ago (2012-09-20 17:41:56 UTC) #2
siva
8 years, 3 months ago (2012-09-20 20:58:40 UTC) #3
LGTM.

Thanks for fixing this.

Maybe at some point we should add an method in class
CallSuperConstructor() which would include all these
filters. There was also the comment about not calling
the super of Object which is an empty method anyway.
We could merge that too. (All this for another CL).

Powered by Google App Engine
This is Rietveld 408576698