Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: runtime/vm/parser.cc

Issue 10963009: Fix implicit super constructor calls for sub-classes of native field wrappers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index e876458bd29e443733cbef9a17a44bf18ca4271e..73e2954da35ec7be83fa90c3f60ebed0b2e7d1a1 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -1517,7 +1517,9 @@ void Parser::GenerateSuperConstructorCall(const Class& cls,
// Omit the implicit super() if there is no super class (i.e.
// we're not compiling class Object), or if the super class is an
// artificially generated "wrapper class" that has no constructor.
- if (super_class.IsNull() || (super_class.num_native_fields() > 0)) {
+ if (super_class.IsNull() ||
+ (super_class.num_native_fields() > 0 &&
+ Class::Handle(super_class.SuperClass()).IsObjectClass())) {
return;
}
String& ctor_name = String::Handle(super_class.Name());
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698