Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1096203007: VM: Use canonical empty-array for empty inlining meta-data. (Closed)

Created:
5 years, 8 months ago by Florian Schneider
Modified:
5 years, 8 months ago
Reviewers:
Cutch, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Use canonical empty-array for empty inlining meta-data. When inlining meta-information is not used, use Object::empty_array() instead of Array::New(0), thus saving those allocations. Guard places for length 0 - before all code objects had an inlining interval array of length at least 1. This saves 2 old-space array allocations per unoptimized code object. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45435

Patch Set 1 #

Patch Set 2 : fixed observatory test #

Patch Set 3 : saved one more array per unoptimized code object #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -39 lines) Patch
M runtime/observatory/tests/service/get_object_rpc_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 3 chunks +34 lines, -28 lines 0 comments Download
M runtime/vm/object.cc View 1 5 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 8 months ago (2015-04-24 12:40:12 UTC) #1
Florian Schneider
+john for observatory test changes.
5 years, 8 months ago (2015-04-24 13:15:52 UTC) #3
srdjan
lgtm
5 years, 8 months ago (2015-04-24 15:38:07 UTC) #4
Florian Schneider
5 years, 8 months ago (2015-04-27 22:50:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r45435 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698