runtime/observatory/tests/service/get_object_rpc_test.dart - Issue 1096203007: VM: Use canonical empty-array for empty inlining meta-data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/get_object_rpc_test.dart

Issue 1096203007: VM: Use canonical empty-array for empty inlining meta-data. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: saved one more array per unoptimized code object Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/observatory/tests/service/get_object_rpc_test.dart

===================================================================

--- runtime/observatory/tests/service/get_object_rpc_test.dart (revision 45397)

+++ runtime/observatory/tests/service/get_object_rpc_test.dart (working copy)

@@ -350,8 +350,8 @@

expect(result['_objectPool'], isNotNull);

expect(result['_disassembly'], isNotNull);

expect(result['_descriptors'], isNotNull);

- expect(result['_inlinedFunctions'], isNotNull);

- expect(result['_inlinedIntervals'], isNotNull);

+ expect(result['_inlinedFunctions'], anyOf([isNull, new isInstanceOf<List>()]));

+ expect(result['_inlinedIntervals'], anyOf([isNull, new isInstanceOf<List>()]));

// invalid code.

« no previous file with comments | « no previous file | runtime/vm/compiler.cc » ('j') | no next file with comments »