Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10962014: Fixes for raw string and block clean ups (Closed)

Created:
8 years, 3 months ago by scheglov
Modified:
8 years, 3 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes for raw string and block clean ups R=danrubel@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12709

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -316 lines) Patch
M compiler/java/com/google/dart/compiler/ast/DartNativeBlock.java View 1 chunk +9 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java View 1 chunk +24 lines, -3 lines 1 comment Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 2 chunks +8 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/AST.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/CleanUpRefactoringWizard.java View 5 chunks +17 lines, -32 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M1_rawString_CleanUp.java View 2 chunks +8 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/style/Style_useBlocks_CleanUp.java View 2 chunks +55 lines, -130 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/MigrateCleanUpTest.java View 1 chunk +38 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/StyleCleanUpTest.java View 4 chunks +4 lines, -142 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 3 months ago (2012-09-20 19:26:56 UTC) #1
danrubel
8 years, 3 months ago (2012-09-21 13:38:42 UTC) #2
LGTM.
This is a pragmatic change that fixes this problem. 
That said, please add a note that we should revisit and cleanup this code.

http://codereview.chromium.org/10962014/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java (right):

http://codereview.chromium.org/10962014/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java:40: public
List<DartStringLiteral> getParts() {
I'm concerned that this approach does not make it apparent to other programmers
that a string literal could also be a concatenation of string literals. A better
change would be to introduce a new node type so that it is obvious to consumers
that they have to deal with two different situations... a single string literal
and concatenated string literals. See com.google.dart.engine.ast.StringLiteral

Powered by Google App Engine
This is Rietveld 408576698