Fixes for raw string and block clean ups

compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java

Index: compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java
diff --git a/compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java b/compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java
index 9d7ee82f7864949a29365e3b72df5096b6e24c55..91c69d95ef2453157f6ca8efc0bc9997f8c15d87 100644
--- a/compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java
+++ b/compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java
@@ -1,28 +1,49 @@
-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.ast;
 
+import com.google.common.collect.ImmutableList;
+
+import java.util.List;
+
 /**
  * Represents a Dart string literal value.
  */
 public class DartStringLiteral extends DartLiteral {
 
   public static DartStringLiteral get(String x) {
-    return new DartStringLiteral(x);
+    return new DartStringLiteral(x, null);
+  }
+
+  public static DartStringLiteral get(String x, List<DartStringLiteral> parts) {
+    return new DartStringLiteral(x, parts);
   }
 
   private final String value;
+  private final List<DartStringLiteral> parts;
 
-  private DartStringLiteral(String value) {
+  private DartStringLiteral(String value, List<DartStringLiteral> parts) {
     this.value = value;
+    this.parts = parts;
   }
 
   public String getValue() {
     return value;
   }
 
+  /**
+   * @return the adjacent literals (separated only by whitespace) which consist this
+   *         {@link DartStringLiteral}.
+   */
+  public List<DartStringLiteral> getParts() {

[danrubel, 2012/09/21 13:38:42]

I'm concerned that this approach does not make it apparent to other programmers
that a string literal could also be a concatenation of string literals. A better
change would be to introduce a new node type so that it is obvious to consumers
that they have to deal with two different situations... a single string literal
and concatenated string literals. See com.google.dart.engine.ast.StringLiteral

+    if (parts == null) {
+      return ImmutableList.of(this);
+    }
+    return parts;
+  }
+
   @Override
   public void visitChildren(ASTVisitor<?> visitor) {
   }