Use native wrapper fields to store socket ids.

Use native wrapper fields to store socket ids.

This relies on landing the change to fix implicit super constructors
for subclasses of something that has native fields.

R=sgjesse@google.com
BUG=dartbug.com/5301

Committed: https://code.google.com/p/dart/source/detail?r=12684

[Søren Gjesse, 2012-09-21 06:47:06]

lgtm

https://codereview.chromium.org/10962012/diff/1/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://codereview.chromium.org/10962012/diff/1/runtime/bin/socket.cc#newcode49
runtime/bin/socket.cc:49: intptr_t socket = 0;
Why do you initialize to 0?

https://codereview.chromium.org/10962012/diff/1/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

https://codereview.chromium.org/10962012/diff/1/runtime/bin/socket_impl.dart#...
runtime/bin/socket_impl.dart:40: _closed = true;
We could consider making this a state with 3 values INIT, OPEN, CLOSED, instead
of having a socket starting out "closed".

[Mads Ager (google), 2012-09-21 08:18:25]

https://codereview.chromium.org/10962012/diff/1/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://codereview.chromium.org/10962012/diff/1/runtime/bin/socket.cc#newcode49
runtime/bin/socket.cc:49: intptr_t socket = 0;
On 2012/09/21 06:47:06, Søren Gjesse wrote:
> Why do you initialize to 0?

Just to make sure that we have some initialization. If for some weird reason the
GetSocketIdNativeField call fails to assign to it, it is nice to have a
recognizable value when something else fails later.

https://codereview.chromium.org/10962012/diff/1/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

https://codereview.chromium.org/10962012/diff/1/runtime/bin/socket_impl.dart#...
runtime/bin/socket_impl.dart:40: _closed = true;
On 2012/09/21 06:47:06, Søren Gjesse wrote:
> We could consider making this a state with 3 values INIT, OPEN, CLOSED,
instead
> of having a socket starting out "closed".

Yes, we could do that to give better error messages. I'd like to postpone that
until we are done moving these to use native fields.