Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: runtime/bin/process.cc

Issue 10962012: Use native wrapper fields to store socket ids. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/process.cc
diff --git a/runtime/bin/process.cc b/runtime/bin/process.cc
index d9dd3d0978794565553bd56b55c84657ccafc973..3526fc6cd51f5a3d89e4430076f53f46557581cb 100644
--- a/runtime/bin/process.cc
+++ b/runtime/bin/process.cc
@@ -4,9 +4,11 @@
#include "bin/dartutils.h"
#include "bin/process.h"
+#include "bin/socket.h"
#include "include/dart_api.h"
+
// Extract an array of C strings from a list of Dart strings.
static char** ExtractCStringList(Dart_Handle strings,
Dart_Handle status_handle,
@@ -132,13 +134,10 @@ void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
&exit_event,
os_error_message, kMaxChildOsErrorMessageLength);
if (error_code == 0) {
- DartUtils::SetIntegerField(in_handle, DartUtils::kIdFieldName, in);
- DartUtils::SetIntegerField(
- out_handle, DartUtils::kIdFieldName, out);
- DartUtils::SetIntegerField(
- err_handle, DartUtils::kIdFieldName, err);
- DartUtils::SetIntegerField(
- exit_handle, DartUtils::kIdFieldName, exit_event);
+ Socket::SetSocketIdNativeField(in_handle, in);
+ Socket::SetSocketIdNativeField(out_handle, out);
+ Socket::SetSocketIdNativeField(err_handle, err);
+ Socket::SetSocketIdNativeField(exit_handle, exit_event);
DartUtils::SetIntegerField(process, "_pid", pid);
} else {
DartUtils::SetIntegerField(

Powered by Google App Engine
This is Rietveld 408576698