Move the addition of an onError handler to earlier (onInit instead of onStart), while still support…

Move the addition of an onError handler to earlier (onInit instead of onStart), while still supporting its removal on onDone and reinstallation in subsequent onStarts.
Committed: https://code.google.com/p/dart/source/detail?r=12658

[Siggi Cherem (dart-lang), 2012-09-20 20:41:31]

lgtm

https://chromiumcodereview.appspot.com/10959025/diff/1/pkg/unittest/html_conf...
File pkg/unittest/html_config.dart (right):

https://chromiumcodereview.appspot.com/10959025/diff/1/pkg/unittest/html_conf...
pkg/unittest/html_config.dart:32: void _removeErrorHandler() {
maybe rename [_removeErrorHandler] to [_uninstallErrorHandler] (to
match/contrast the _install name above)

https://chromiumcodereview.appspot.com/10959025/diff/1/pkg/unittest/html_conf...
pkg/unittest/html_config.dart:52: _removeErrorHandler();
since the idea of detaching/reataching it is mostly for the interactive config,
you could make that this config doesn't install/remove it on onStart/onDone, but
only sets it up once on onInit

https://chromiumcodereview.appspot.com/10959025/diff/1/pkg/unittest/html_enha...
File pkg/unittest/html_enhanced_config.dart (right):

https://chromiumcodereview.appspot.com/10959025/diff/1/pkg/unittest/html_enha...
pkg/unittest/html_enhanced_config.dart:34: void _removeErrorHandler() {
ditto (rename)

[gram, 2012-09-20 20:48:29]

https://chromiumcodereview.appspot.com/10959025/diff/1/pkg/unittest/html_conf...
File pkg/unittest/html_config.dart (right):

https://chromiumcodereview.appspot.com/10959025/diff/1/pkg/unittest/html_conf...
pkg/unittest/html_config.dart:32: void _removeErrorHandler() {
On 2012/09/20 20:41:31, sigmund wrote:
> maybe rename [_removeErrorHandler] to [_uninstallErrorHandler] (to
> match/contrast the _install name above)

Done.

https://chromiumcodereview.appspot.com/10959025/diff/1/pkg/unittest/html_conf...
pkg/unittest/html_config.dart:52: _removeErrorHandler();
On 2012/09/20 20:41:31, sigmund wrote:
> since the idea of detaching/reataching it is mostly for the interactive
config,
> you could make that this config doesn't install/remove it on onStart/onDone,
but
> only sets it up once on onInit

Done.

https://chromiumcodereview.appspot.com/10959025/diff/1/pkg/unittest/html_enha...
File pkg/unittest/html_enhanced_config.dart (right):

https://chromiumcodereview.appspot.com/10959025/diff/1/pkg/unittest/html_enha...
pkg/unittest/html_enhanced_config.dart:34: void _removeErrorHandler() {
On 2012/09/20 20:41:31, sigmund wrote:
> ditto (rename)

Done.

[Emily Fortuna, 2012-09-20 20:53:15]

lgtm