Move the addition of an onError handler to earlier (onInit instead of onStart), while still support…

pkg/unittest/html_enhanced_config.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A simple unit test library for running tests in a browser.
  *
  * Provides enhanced HTML output with collapsible group headers
  * and other at-a-glance information about the test results.
  */
 #library('unittest');
 
 #import('dart:html');
 #import('unittest.dart');
 
 
 class HtmlEnhancedConfiguration extends Configuration {
   /** Whether this is run within dartium layout tests. */
   final bool _isLayoutTest;
   HtmlEnhancedConfiguration(this._isLayoutTest);
 
   // TODO(rnystrom): Get rid of this if we get canonical closures for methods.
   EventListener _onErrorClosure;
 
+  void _installErrorHandler() {
+    if (_onErrorClosure == null) {
+      _onErrorClosure =
+          (e) => handleExternalError(e, '(DOM callback has errors)');
+      // Listen for uncaught errors.
+      window.on.error.add(_onErrorClosure);
+    }
+  }
+
+  void _uninstallErrorHandler() {
+    if (_onErrorClosure != null) {
+      window.on.error.remove(_onErrorClosure);
+      _onErrorClosure = null;
+    }
+  }
+
   void onInit() {
+    _installErrorHandler();
     //initialize and load CSS
     final String _CSSID = '_unittestcss_';
 
     var cssElement = document.head.query('#${_CSSID}');
     if (cssElement == null){
       document.head.elements.add(new Element.html(
           '<style id="${_CSSID}"></style>'));
       cssElement = document.head.query('#${_CSSID}');
     }
 
     cssElement.innerHTML = _htmlTestCSS;
-
-    _onErrorClosure =
-        (e) => handleExternalError(e, '(DOM callback has errors)');
   }
 
   void onStart() {
     window.postMessage('unittest-suite-wait-for-done', '*');
     // Listen for uncaught errors.
     window.on.error.add(_onErrorClosure);
   }
 
   void onTestResult(TestCase testCase) {}
 
   void onDone(int passed, int failed, int errors, List<TestCase> results,
       String uncaughtError) {
-    window.on.error.remove(_onErrorClosure);
+    _uninstallErrorHandler();
 
     _showInteractiveResultsInPage(passed, failed, errors, results,
         _isLayoutTest, uncaughtError);
 
     window.postMessage('unittest-suite-done', '*');
   }
 
   void _showInteractiveResultsInPage(int passed, int failed, int errors,
       List<TestCase> results, bool isLayoutTest, String uncaughtError) {
     if (isLayoutTest && passed == results.length) {
@@ skipping 310 matching lines @@
   .unittest-row-description
   {
   }
 
   ''';
 }
 
 void useHtmlEnhancedConfiguration([bool isLayoutTest = false]) {
   configure(new HtmlEnhancedConfiguration(isLayoutTest));
 }