Issue 10950006: Convert most interfaces in dart:core to abstract classes.

Issue 10950006: Convert most interfaces in dart:core to abstract classes. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Convert most interfaces in dart:core to abstract classes. Committed: https://code.google.com/p/dart/source/detail?r=12494

Patch Set 2 : Address review comments. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -186 lines)			Patch
M	lib/compiler/implementation/lib/coreimpl.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/core/date.dart	View		3 chunks	+22 lines, -14 lines	0 comments	Download
M	lib/core/duration.dart	View		2 chunks	+82 lines, -28 lines	0 comments	Download
M	lib/core/exceptions.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/core/expect.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/core/future.dart	View		3 chunks	+4 lines, -6 lines	0 comments	Download
M	lib/core/num.dart	View		1 chunk	+26 lines, -26 lines	0 comments	Download
M	lib/core/options.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/core/queue.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/core/regexp.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/core/set.dart	View		2 chunks	+9 lines, -8 lines	0 comments	Download
M	lib/core/stopwatch.dart	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	lib/core/string_buffer.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/core/strings.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/coreimpl/collections.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/coreimpl/coreimpl.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/coreimpl/corelib_impl_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/coreimpl/date.dart	View	1	2 chunks	+9 lines, -8 lines	0 comments	Download
D	lib/coreimpl/duration_implementation.dart	View		1 chunk	+0 lines, -74 lines	0 comments	Download
M	lib/coreimpl/exceptions.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/coreimpl/string_buffer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://chromiumcodereview.appspot.com/10950006/diff/1/lib/core/date.dart File lib/core/date.dart (right): https://chromiumcodereview.appspot.com/10950006/diff/1/lib/core/date.dart#newcode83 lib/core/date.dart:83: // TODO(lrn): Have two constructors instead of taking ...

8 years, 3 months ago (2012-09-18 12:30:56 UTC) #2

Lasse Reichstein Nielsen

8 years, 3 months ago (2012-09-18 12:39:42 UTC) #3

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/core/date.dart
File lib/core/date.dart (right):

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/core/date.dart#new...
lib/core/date.dart:83: // TODO(lrn): Have two constructors instead of taking an
optional bool.
It's going to have to be consistent with the Date constructor, and that can't
have both positional and named optional parameters. I expect it will change into
an UTC version and a non-UTC version, both with optional positional parameters.

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/core/exceptions.dart
File lib/core/exceptions.dart (right):

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/core/exceptions.da...
lib/core/exceptions.dart:11: interface Exception default ExceptionImplementation
{
You assume correctly.
I'm not sure exactly how to do this yet, but I definitely want to do something.
That is: Not in this CL.

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/coreimpl/collectio...
File lib/coreimpl/collections.dart (right):

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/coreimpl/collectio...
lib/coreimpl/collections.dart:141: result.add(o.toString());
Yeah. I don't like passing non-strings to StringBuffer, but I guess it's
currently allowed.

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/coreimpl/date.dart
File lib/coreimpl/date.dart (right):

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/coreimpl/date.dart...
lib/coreimpl/date.dart:163: [int month = 1,
Adding TODO for now. This is an external constructor, so it'll also require
changing of the patches, which is outside the scope of this CL.

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/coreimpl/exception...
File lib/coreimpl/exceptions.dart (right):

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/coreimpl/exception...
lib/coreimpl/exceptions.dart:6: final message;
Eventually, yes.

https://chromiumcodereview.appspot.com/10950006/diff/1/lib/coreimpl/exception...
lib/coreimpl/exceptions.dart:8: String toString() => (message == null) ?
"Exception" : "Exception: $message";
The problem with "throwables" is that their toString is used to print uncaught
exceptions, and they should be readable.

Expand Messages | Collapse Messages