Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: lib/coreimpl/collections.dart

Issue 10950006: Convert most interfaces in dart:core to abstract classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « lib/core/strings.dart ('k') | lib/coreimpl/coreimpl.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * The [Collections] class implements static methods useful when 6 * The [Collections] class implements static methods useful when
7 * writing a class that implements [Collection] and the [iterator] 7 * writing a class that implements [Collection] and the [iterator]
8 * method. 8 * method.
9 */ 9 */
10 class Collections { 10 class Collections {
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 } else { 131 } else {
132 _emitCollection(o, result, visiting); 132 _emitCollection(o, result, visiting);
133 } 133 }
134 } else if (o is Map) { 134 } else if (o is Map) {
135 if (_containsRef(visiting, o)) { 135 if (_containsRef(visiting, o)) {
136 result.add('{...}'); 136 result.add('{...}');
137 } else { 137 } else {
138 Maps._emitMap(o, result, visiting); 138 Maps._emitMap(o, result, visiting);
139 } 139 }
140 } else { // o is neither a collection nor a map 140 } else { // o is neither a collection nor a map
141 result.add(o == null ? 'null' : o); // TODO(jjb): remove the null check 141 result.add(o);
142 } 142 }
143 } 143 }
144 144
145 /** 145 /**
146 * Returns true if the specified collection contains the specified object 146 * Returns true if the specified collection contains the specified object
147 * reference. 147 * reference.
148 */ 148 */
149 static _containsRef(Collection c, Object ref) { 149 static _containsRef(Collection c, Object ref) {
150 for (var e in c) { 150 for (var e in c) {
151 if (e === ref) return true; 151 if (e === ref) return true;
152 } 152 }
153 return false; 153 return false;
154 } 154 }
155 } 155 }
OLDNEW
« no previous file with comments | « lib/core/strings.dart ('k') | lib/coreimpl/coreimpl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698