Issue 10949026: Allow circular dependencies on the root source in Pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10949026: Allow circular dependencies on the root source in Pub. (Closed)

Created:
8 years, 3 months ago by nweiz

Modified:
8 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow circular dependencies on the root source in Pub. BUG=5300 Committed: https://code.google.com/p/dart/source/detail?r=12817

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -54 lines)			Patch
	M	utils/pub/version_solver.dart	View		5 chunks	+59 lines, -39 lines	2 comments	Download
	M	utils/tests/pub/version_solver_test.dart	View		14 chunks	+80 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. The versionsolver code feels a bit hairy to me. I was thinking it might ...

8 years, 3 months ago (2012-09-20 01:19:54 UTC) #2

nweiz

8 years, 3 months ago (2012-09-24 22:31:16 UTC) #3

I don't think storing a separate root ref is the way to go; I think that'll add
more special cases than it'll remove.

https://codereview.chromium.org/10949026/diff/1/utils/pub/version_solver.dart
File utils/pub/version_solver.dart (right):

https://codereview.chromium.org/10949026/diff/1/utils/pub/version_solver.dart...
utils/pub/version_solver.dart:188: if (seen.contains(dependency.name)) return
false;
On 2012/09/20 01:19:54, Bob Nystrom wrote:
> How about a comment: // Avoid infinite loop if the graph has cycles.

Done.

Expand Messages | Collapse Messages