Allow circular dependencies on the root source in Pub.

utils/tests/pub/version_solver_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('pub_update_test');
 
 #import('dart:io');
 #import('dart:isolate');
 
 #import('../../pub/lock_file.dart');
 #import('../../pub/package.dart');
 #import('../../pub/pubspec.dart');
+#import('../../pub/root_source.dart');
 #import('../../pub/source.dart');
 #import('../../pub/source_registry.dart');
 #import('../../pub/utils.dart');
 #import('../../pub/version.dart');
 #import('../../pub/version_solver.dart');
 #import('../../../pkg/unittest/unittest.dart');
 
 final noVersion = 'no version';
 final disjointConstraint = 'disjoint';
 final sourceMismatch = 'source mismatch';
 final descriptionMismatch = 'description mismatch';
 final couldNotSolve = 'unsolved';
 
 Source source1;
 Source source2;
 Source versionlessSource;
+Source rootSource;
 
 main() {
   testResolve('no dependencies', {
     'myapp 0.0.0': {}
   }, result: {
-    'myapp': '0.0.0'
+    'myapp from root': '0.0.0'
   });
 
   testResolve('simple dependency tree', {
     'myapp 0.0.0': {
       'a': '1.0.0',
       'b': '1.0.0'
     },
     'a 1.0.0': {
       'aa': '1.0.0',
       'ab': '1.0.0'
     },
     'aa 1.0.0': {},
     'ab 1.0.0': {},
     'b 1.0.0': {
       'ba': '1.0.0',
       'bb': '1.0.0'
     },
     'ba 1.0.0': {},
     'bb 1.0.0': {}
   }, result: {
-    'myapp': '0.0.0',
+    'myapp from root': '0.0.0',
     'a': '1.0.0',
     'aa': '1.0.0',
     'ab': '1.0.0',
     'b': '1.0.0',
     'ba': '1.0.0',
     'bb': '1.0.0'
   });
 
   testResolve('shared dependency with overlapping constraints', {
     'myapp 0.0.0': {
       'a': '1.0.0',
       'b': '1.0.0'
     },
     'a 1.0.0': {
       'shared': '>=2.0.0 <4.0.0'
     },
     'b 1.0.0': {
       'shared': '>=3.0.0 <5.0.0'
     },
     'shared 2.0.0': {},
     'shared 3.0.0': {},
     'shared 3.6.9': {},
     'shared 4.0.0': {},
     'shared 5.0.0': {},
   }, result: {
-    'myapp': '0.0.0',
+    'myapp from root': '0.0.0',
     'a': '1.0.0',
     'b': '1.0.0',
     'shared': '3.6.9'
   });
 
   testResolve('shared dependency where dependent version in turn affects '
               'other dependencies', {
     'myapp 0.0.0': {
       'foo': '<=1.0.2',
       'bar': '1.0.0'
     },
     'foo 1.0.0': {},
     'foo 1.0.1': { 'bang': '1.0.0' },
     'foo 1.0.2': { 'whoop': '1.0.0' },
     'foo 1.0.3': { 'zoop': '1.0.0' },
     'bar 1.0.0': { 'foo': '<=1.0.1' },
     'bang 1.0.0': {},
     'whoop 1.0.0': {},
     'zoop 1.0.0': {}
   }, result: {
-    'myapp': '0.0.0',
+    'myapp from root': '0.0.0',
     'foo': '1.0.1',
     'bar': '1.0.0',
     'bang': '1.0.0'
   });
 
   testResolve('from versionless source', {
     'myapp 0.0.0': {
       'foo from versionless': 'any'
     },
     'foo 1.2.3 from versionless': {}
   }, result: {
-    'myapp': '0.0.0',
-    'foo': '1.2.3'
+    'myapp from root': '0.0.0',
+    'foo from versionless': '1.2.3'
   });
 
   testResolve('transitively through versionless source', {
     'myapp 0.0.0': {
       'foo from versionless': 'any'
     },
     'foo 1.2.3 from versionless': {
       'bar': '>=1.0.0'
     },
     'bar 1.1.0': {}
   }, result: {
-    'myapp': '0.0.0',
-    'foo': '1.2.3',
+    'myapp from root': '0.0.0',
+    'foo from versionless': '1.2.3',
     'bar': '1.1.0'
   });
 
   testResolve('with compatible locked dependency', {
     'myapp 0.0.0': {
       'foo': 'any'
     },
     'foo 1.0.0': { 'bar': '1.0.0' },
     'foo 1.0.1': { 'bar': '1.0.1' },
     'foo 1.0.2': { 'bar': '1.0.2' },
     'bar 1.0.0': {},
     'bar 1.0.1': {},
     'bar 1.0.2': {}
   }, lockfile: {
     'foo': '1.0.1'
   }, result: {
-    'myapp': '0.0.0',
+    'myapp from root': '0.0.0',
     'foo': '1.0.1',
     'bar': '1.0.1'
   });
 
   testResolve('with incompatible locked dependency', {
     'myapp 0.0.0': {
       'foo': '>1.0.1'
     },
     'foo 1.0.0': { 'bar': '1.0.0' },
     'foo 1.0.1': { 'bar': '1.0.1' },
     'foo 1.0.2': { 'bar': '1.0.2' },
     'bar 1.0.0': {},
     'bar 1.0.1': {},
     'bar 1.0.2': {}
   }, lockfile: {
     'foo': '1.0.1'
   }, result: {
-    'myapp': '0.0.0',
+    'myapp from root': '0.0.0',
     'foo': '1.0.2',
     'bar': '1.0.2'
   });
 
   testResolve('with unrelated locked dependency', {
     'myapp 0.0.0': {
       'foo': 'any'
     },
     'foo 1.0.0': { 'bar': '1.0.0' },
     'foo 1.0.1': { 'bar': '1.0.1' },
     'foo 1.0.2': { 'bar': '1.0.2' },
     'bar 1.0.0': {},
     'bar 1.0.1': {},
     'bar 1.0.2': {},
     'baz 1.0.0': {}
   }, lockfile: {
     'baz': '1.0.0'
   }, result: {
-    'myapp': '0.0.0',
+    'myapp from root': '0.0.0',
     'foo': '1.0.2',
     'bar': '1.0.2'
   });
 
+  testResolve('circular dependency', {
+    'myapp 1.0.0': {
+      'foo': '1.0.0'
+    },
+    'foo 1.0.0': {
+      'bar': '1.0.0'
+    },
+    'bar 1.0.0': {
+      'foo': '1.0.0'
+    }
+  }, result: {
+    'myapp from root': '1.0.0',
+    'foo': '1.0.0',
+    'bar': '1.0.0'
+  });
+
   testResolve('dependency back onto root package', {
     'myapp 1.0.0': {
       'foo': '1.0.0'
     },
     'foo 1.0.0': {
+      'myapp from root': '>=1.0.0'
+    }
+  }, result: {
+    'myapp from root': '1.0.0',
+    'foo': '1.0.0'
+  });
+
+  testResolve('dependency back onto root package with different source', {
+    'myapp 1.0.0': {
+      'foo': '1.0.0'
+    },
+    'foo 1.0.0': {
       'myapp': '>=1.0.0'
     }
+  }, result: {
+    'myapp from root': '1.0.0',
+    'foo': '1.0.0'
+  });
+
+  testResolve('mismatched dependencies back onto root package', {
+    'myapp 1.0.0': {
+      'foo': '1.0.0',
+      'bar': '1.0.0'
+    },
+    'foo 1.0.0': {
+      'myapp': '>=1.0.0'
+    },
+    'bar 1.0.0': {
+      'myapp from mock2': '>=1.0.0'
+    }
   }, error: sourceMismatch);
 
+  testResolve('dependency back onto root package with wrong version', {
+    'myapp 1.0.0': {
+      'foo': '1.0.0'
+    },
+    'foo 1.0.0': {
+      'myapp': '<1.0.0'
+    }
+  }, error: disjointConstraint);
+
   testResolve('no version that matches requirement', {
     'myapp 0.0.0': {
       'foo': '>=1.0.0 <2.0.0'
     },
     'foo 2.0.0': {},
     'foo 2.1.3': {}
   }, error: noVersion);
 
   testResolve('no version that matches combined constraint', {
     'myapp 0.0.0': {
@@ skipping 97 matching lines @@
       var parts = nameVersion.split(' ');
       var name = parts[0];
       var version = parts[1];
 
       var package = source1.mockPackage(name, version, dependencies);
       if (name == 'myapp') {
         // Don't add the root package to the server, so we can verify that Pub
         // doesn't try to look up information about the local package on the
         // remote server.
         root = package;
+        rootSource = new RootSource(root);
+        sources.register(rootSource);
       } else {
         source.addPackage(package);
       }
     });
 
     // Clean up the expectation.
     if (result != null) {
+      var newResult = {};
       result.forEach((name, version) {
-        result[name] = new Version.parse(version);
+        var parsed = parseSource(name);
+        name = parsed.first;
+        var source = parsed.last;
+        version = new Version.parse(version);
+        newResult[name] = new PackageId(name, source, version, name);
       });
+      result = newResult;
     }
 
     var realLockFile = new LockFile.empty();
     if (lockfile != null) {
       lockfile.forEach((name, version) {
         version = new Version.parse(version);
         realLockFile.packages[name] =
           new PackageId(name, source1, version, name);
       });
     }
 
     // Resolve the versions.
     var future = resolveVersions(sources, root, realLockFile);
 
     if (result != null) {
       expect(future, completion(predicate((actualResult) {
-        for (var id in actualResult) {
-          if (!result.containsKey(id.description)) return false;
-          if (id.version != result.remove(id.description)) return false;
+        for (var actualId in actualResult) {
+          if (!result.containsKey(actualId.name)) return false;
+          var expectedId = result.remove(actualId.name);
+          if (actualId != expectedId) return false;
         }
         return result.isEmpty();
       }, description: 'packages to match $result')));
     } else if (error == noVersion) {
       expect(future, throwsA(new isInstanceOf<NoVersionException>()));
     } else if (error == disjointConstraint) {
       expect(future, throwsA(new isInstanceOf<DisjointConstraintException>()));
     } else if (error == sourceMismatch) {
       expect(future, throwsA(new isInstanceOf<SourceMismatchException>()));
     } else if (error == descriptionMismatch) {
@@ skipping 103 matching lines @@
 
   return completer.future;
 }
 
 Pair<String, Source> parseSource(String name) {
   var match = new RegExp(@"(.*) from (.*)").firstMatch(name);
   if (match == null) return new Pair<String, Source>(name, source1);
   switch (match[2]) {
   case 'mock1': return new Pair<String, Source>(match[1], source1);
   case 'mock2': return new Pair<String, Source>(match[1], source2);
+  case 'root': return new Pair<String, Source>(match[1], rootSource);
   case 'versionless':
     return new Pair<String, Source>(match[1], versionlessSource);
   }
 }