Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 10946038: Fixed a nasty bug in unittest, where is we have a non-async test that throws an exception, followed… (Closed)

Created:
8 years, 3 months ago by gram
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixed a nasty bug in unittest, where is we have a non-async test that throws an exception, followed by an async test, the async test will not block and can end up 'passing' with no result set. The problem is that when we throw the exception in the non-async test we don't break out of _nextBatch and we also add a call to _nextTestCase in _registerException. We should only do one of these; basically if the test is not async then we just stay in the _nextBatch loop; if it is async then we kick off the next test from in registerException. Committed: https://code.google.com/p/dart/source/detail?r=12606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M pkg/unittest/test/unittest_test.dart View 3 chunks +14 lines, -2 lines 0 comments Download
M pkg/unittest/unittest.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
gram
8 years, 3 months ago (2012-09-19 21:04:33 UTC) #1
Siggi Cherem (dart-lang)
8 years, 3 months ago (2012-09-19 21:10:38 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698