Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: pkg/unittest/unittest.dart

Issue 10946038: Fixed a nasty bug in unittest, where is we have a non-async test that throws an exception, followed… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/unittest/test/unittest_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/unittest.dart
===================================================================
--- pkg/unittest/unittest.dart (revision 12573)
+++ pkg/unittest/unittest.dart (working copy)
@@ -759,7 +759,8 @@
} else {
_tests[testNum].error('Caught $e', trace);
}
- if (testNum == _currentTest) {
+ if (testNum == _currentTest &&
+ _tests[testNum].callbackFunctionsOutstanding > 0) {
_nextTestCase();
}
}
@@ -789,6 +790,7 @@
/** Publish results on the page and notify controller. */
_completeTests() {
+ if (!_initialized) return;
int testsPassed_ = 0;
int testsFailed_ = 0;
int testsErrors_ = 0;
« no previous file with comments | « pkg/unittest/test/unittest_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698