Issue 10944034: Make copy of flags before passing it to TestCompiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10944034: Make copy of flags before passing it to TestCompiler (Closed)

Created:
8 years, 3 months ago by ricow1

Modified:
8 years, 3 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make copy of flags before passing it to TestCompiler We are adding to the flags in the TestCompiler function and are duplicating flags since we might call it again. Committed: https://code.google.com/p/dart/source/detail?r=12579

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	utils/compiler/buildbot.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm!

Expand Messages | Collapse Messages