Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: utils/compiler/buildbot.py

Issue 10944034: Make copy of flags before passing it to TestCompiler (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Dart2js buildbot steps 7 """Dart2js buildbot steps
8 8
9 Runs tests for the dart2js compiler. 9 Runs tests for the dart2js compiler.
10 """ 10 """
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 test_flags = [] 384 test_flags = []
385 if build_info.shard_index: 385 if build_info.shard_index:
386 test_flags = ['--shards=%s' % build_info.total_shards, 386 test_flags = ['--shards=%s' % build_info.total_shards,
387 '--shard=%s' % build_info.shard_index] 387 '--shard=%s' % build_info.shard_index]
388 388
389 if build_info.checked: test_flags += ['--checked'] 389 if build_info.checked: test_flags += ['--checked']
390 390
391 if build_info.host_checked: test_flags += ['--host-checked'] 391 if build_info.host_checked: test_flags += ['--host-checked']
392 392
393 status = TestCompiler(build_info.runtime, build_info.mode, 393 status = TestCompiler(build_info.runtime, build_info.mode,
394 build_info.system, test_flags, 394 build_info.system, list(test_flags),
395 build_info.is_buildbot, build_info.test_set) 395 build_info.is_buildbot, build_info.test_set)
396 396
397 # See comment in GetHasHardCodedCheckedMode, this is a hack. 397 # See comment in GetHasHardCodedCheckedMode, this is a hack.
398 if (status == 0 and GetHasHardCodedCheckedMode(build_info)): 398 if (status == 0 and GetHasHardCodedCheckedMode(build_info)):
399 status = TestCompiler(build_info.runtime, build_info.mode, 399 status = TestCompiler(build_info.runtime, build_info.mode,
400 build_info.system, 400 build_info.system,
401 test_flags + ['--checked'], 401 test_flags + ['--checked'],
402 build_info.is_buildbot, 402 build_info.is_buildbot,
403 build_info.test_set) 403 build_info.test_set)
404 404
405 if build_info.runtime != 'd8': CleanUpTemporaryFiles(build_info.system, 405 if build_info.runtime != 'd8': CleanUpTemporaryFiles(build_info.system,
406 build_info.runtime) 406 build_info.runtime)
407 if status != 0: print '@@@STEP_FAILURE@@@' 407 if status != 0: print '@@@STEP_FAILURE@@@'
408 return status 408 return status
409 409
410 if __name__ == '__main__': 410 if __name__ == '__main__':
411 sys.exit(main()) 411 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698