Issue 10944010: Change utils/compiler/buildbot.py to use our new naming schema.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10944010: Change utils/compiler/buildbot.py to use our new naming schema. (Closed)

Created:
8 years, 3 months ago by ricow1

Modified:
8 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change utils/compiler/buildbot.py to use our new naming schema. Additionally, some cleanup and update of comments regarding return tupples and parameters. Committed: https://code.google.com/p/dart/source/detail?r=12530

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -38 lines)			Patch
	M	utils/compiler/buildbot.py	View	1	8 chunks	+55 lines, -38 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/10944010/diff/1/utils/compiler/buildbot.py File utils/compiler/buildbot.py (right): https://codereview.chromium.org/10944010/diff/1/utils/compiler/buildbot.py#newcode338 utils/compiler/buildbot.py:338: print "compiler: %s, runtime: %s mode: %s, system: ...

8 years, 3 months ago (2012-09-18 13:55:05 UTC) #2

ricow1

8 years, 3 months ago (2012-09-18 14:04:02 UTC) #3

https://codereview.chromium.org/10944010/diff/1/utils/compiler/buildbot.py
File utils/compiler/buildbot.py (right):

https://codereview.chromium.org/10944010/diff/1/utils/compiler/buildbot.py#ne...
utils/compiler/buildbot.py:338: print "compiler: %s, runtime: %s mode: %s,
system: %s,"\
On 2012/09/18 13:55:05, ahe wrote:
> Use parentheses, not \ to join lines.

Done

https://codereview.chromium.org/10944010/diff/1/utils/compiler/buildbot.py#ne...
utils/compiler/buildbot.py:368: print("ran first");
On 2012/09/18 13:55:05, ahe wrote:
> Debug code? Or print something a little more meaningful.
Ups, removed

Expand Messages | Collapse Messages