Change utils/compiler/buildbot.py to use our new naming schema.

utils/compiler/buildbot.py

 #!/usr/bin/python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Dart2js buildbot steps
 
 Runs tests for the  dart2js compiler.
 """
 
 import platform
 import optparse
 import os
 import re
 import shutil
 import subprocess
 import sys
 
 BUILDER_NAME = 'BUILDBOT_BUILDERNAME'
 BUILDER_CLOBBER = 'BUILDBOT_CLOBBER'
 
 
 DART_PATH = os.path.dirname(
     os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 DART2JS_BUILDER = (
-    r'dart2js-(linux|mac|windows)-(debug|release)(-([a-z]+))?-?(\d*)-?(\d*)')
+    r'dart2js-(linux|mac|windows)-(debug|release)(-(checked|host-checked))?(-(host-checked))?-?(\d*)-?(\d*)')
+# TODO(ricow): rename all builders from web- to dart2js-.
 WEB_BUILDER = (
-    r'web-(ie|ff|safari|chrome|opera)-(win7|win8|mac|linux)-?(\d*)-?(\d*)')
+    r'(dart2js|web)-(ie|ff|safari|chrome|opera)-(win7|win8|mac|linux)-?(\d*)-?(\d*)')
 
 NO_COLOR_ENV = dict(os.environ)
 NO_COLOR_ENV['TERM'] = 'nocolor'
 
 def GetBuildInfo():
-  """Returns a tuple (compiler, runtime, mode, system, option) where:
+  """Returns a tuple (compiler, runtime, mode, system, checked, host_checked,
+                      shard_index, total_shards, is_buildbot) where:
     - compiler: 'dart2js' or None when the builder has an incorrect name
     - runtime: 'd8', 'ie', 'ff', 'safari', 'chrome', 'opera'
     - mode: 'debug' or 'release'
     - system: 'linux', 'mac', or 'win7'
-    - option: 'checked'
+    - checked: True if we should run in checked mode, otherwise False
+    - host_checked: True if we should run in host checked mode, otherwise False
+    - shard_index: The shard we are running, None when not specified.
+    - total_shards: The total number of shards, None when not specified.
+    - is_buildbot: True if we are on a buildbot (or emulating it).
   """
   parser = optparse.OptionParser()
   parser.add_option('-n', '--name', dest='name', help='The name of the build'
       'bot you would like to emulate (ex: web-chrome-win7)', default=None)
   args, _ = parser.parse_args()
 
   compiler = None
   runtime = None
   mode = None
   system = None
   builder_name = os.environ.get(BUILDER_NAME)
-  option = None
+  checked = False
+  host_checked = False
   shard_index = None
   total_shards = None
   is_buildbot = True
   if not builder_name:
     # We are not running on a buildbot.
     is_buildbot = False
     if args.name:
       builder_name = args.name
     else:
       print 'Use -n $BUILDBOT_NAME for the bot you would like to emulate.'
       sys.exit(1)
 
   if builder_name:
     dart2js_pattern = re.match(DART2JS_BUILDER, builder_name)
     web_pattern = re.match(WEB_BUILDER, builder_name)
 
-    if dart2js_pattern:
+    if web_pattern:
+      compiler = 'dart2js'
+      runtime = web_pattern.group(2)
+      system = web_pattern.group(3)
+      mode = 'release'
+      shard_index = web_pattern.group(3)
+      total_shards = web_pattern.group(4)
+    elif dart2js_pattern:
       compiler = 'dart2js'
       runtime = 'd8'
       system = dart2js_pattern.group(1)
       mode = dart2js_pattern.group(2)
-      option = dart2js_pattern.group(4)
-      shard_index = dart2js_pattern.group(5)
-      total_shards = dart2js_pattern.group(6)
-
-    elif web_pattern:
-      compiler = 'dart2js'
-      runtime = web_pattern.group(1)
-      system = web_pattern.group(2)
-      mode = 'release'
-      shard_index = web_pattern.group(3)
-      total_shards = web_pattern.group(4)
+      # The valid naming parts for checked and host-checked are:
+      # Empty: checked=False, host_checked=False
+      # -checked: checked=True, host_checked=False
+      # -host-checked: checked=False, host_checked=True
+      # -checked-host-checked: checked=True, host_checked=True
+      if dart2js_pattern.group(4) == 'checked':
+        checked = True
+      if dart2js_pattern.group(4) == 'host-checked':
+        host_checked = True
+      if dart2js_pattern.group(6) == 'host-checked':
+        host_checked = True
+      shard_index = dart2js_pattern.group(7)
+      total_shards = dart2js_pattern.group(8)
 
   if system == 'windows':
     system = 'win7'
 
   if (system == 'win7' and platform.system() != 'Windows') or (
       system == 'mac' and platform.system() != 'Darwin') or (
       system == 'linux' and platform.system() != 'Linux'):
     print ('Error: You cannot emulate a buildbot with a platform different '
         'from your own.')
     sys.exit(1)
-  return (compiler, runtime, mode, system, option, shard_index, total_shards,
-          is_buildbot)
+  return (compiler, runtime, mode, system, checked, host_checked, shard_index,
+          total_shards, is_buildbot)
 
 
 def NeedsXterm(compiler, runtime):
   return runtime in ['ie', 'chrome', 'safari', 'opera', 'ff', 'drt']
 
 
 def TestStepName(name, flags):
   # Filter out flags with '=' as this breaks the /stats feature of the
   # build bot.
   flags = [x for x in flags if not '=' in x]
@@ skipping 43 matching lines @@
      - mode: either 'debug' or 'release'
      - system: either 'linux', 'mac', or 'win7'
   """
   os.chdir(DART_PATH)
 
   args = [sys.executable, './tools/build.py', '--mode=' + mode, 'create_sdk']
   print 'running %s' % (' '.join(args))
   return subprocess.call(args, env=NO_COLOR_ENV)
 
 
-def TestCompiler(runtime, mode, system, option, flags, is_buildbot):
+def TestCompiler(runtime, mode, system, flags, is_buildbot):
   """ test the compiler.
    Args:
      - runtime: either 'd8', or one of the browsers, see GetBuildInfo
      - mode: either 'debug' or 'release'
      - system: either 'linux', 'mac', or 'win7'
-     - option: 'checked'
      - flags: extra flags to pass to test.dart
      - is_buildbot: true if we are running on a real buildbot instead of
        emulating one.
   """
 
   # Make sure we are in the dart directory
   os.chdir(DART_PATH)
 
   if system.startswith('win') and runtime == 'ie':
     # TODO(ahe): This pre-dates the shard feature and should be
@@ skipping 47 matching lines @@
     p = subprocess.Popen(version_query_string,
         stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True)
     output, stderr = p.communicate()
     output = output.split()
     try:
       print 'Version of %s: %s' % (runtime, output[-1])
     except IndexError:
       # Failed to obtain version information. Continue running tests.
       pass
 
-  if option == 'checked': flags = flags + ['--host-checked']
-
   if runtime == 'd8':
     # The dart2js compiler isn't self-hosted (yet) so we run its
     # unit tests on the VM. We avoid doing this on the builders
     # that run the browser tests to cut down on the cycle time.
     TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js'], flags)
 
   if not (system.startswith('win') and runtime == 'ie'):
     # Run the default set of test suites.
     TestStep("dart2js", mode, system, 'dart2js', runtime, [], flags)
 
@@ skipping 63 matching lines @@
   return subprocess.call(cmd, env=NO_COLOR_ENV)
 
 def GetShouldClobber():
   return os.environ.get(BUILDER_CLOBBER) == "1"
 
 def main():
   if len(sys.argv) == 0:
     print 'Script pathname not known, giving up.'
     return 1
 
-  (compiler, runtime, mode, system, option, shard_index, total_shards,
-      is_buildbot) = GetBuildInfo()
+  (compiler, runtime, mode, system, checked, host_checked, shard_index,
+   total_shards, is_buildbot) = GetBuildInfo()
   shard_description = ""
   if shard_index:
     shard_description = " shard %s of %s" % (shard_index, total_shards)
-  print "compiler: %s, runtime: %s mode: %s, system: %s, option: %s%s" % (
-      compiler, runtime, mode, system, option, shard_description)
+  print "compiler: %s, runtime: %s mode: %s, system: %s,"\

[ahe, 2012/09/18 13:55:05]

Use parentheses, not \ to join lines.

[ricow1, 2012/09/18 14:04:02]

Done

+        " checked: %s, host-checked: %s%s" % (compiler, runtime, mode, system,
+                                              checked, host_checked,
+                                              shard_description)
+
   if compiler is None:
     return 1
 
   if GetShouldClobber():
     print '@@@BUILD_STEP Clobber@@@'
     status = ClobberBuilder(mode)
     if status != 0:
       print '@@@STEP_FAILURE@@@'
       return status
 
   print '@@@BUILD_STEP build sdk@@@'
   status = BuildSDK(mode, system)
   if status != 0:
     print '@@@STEP_FAILURE@@@'
     return status
 
   test_flags = []
   if shard_index:
     test_flags = ['--shards=%s' % total_shards, '--shard=%s' % shard_index]
 
-  # First we run all the regular tests.
-  status = TestCompiler(runtime, mode, system, option, test_flags,
-                        is_buildbot)
+  if checked: test_flags += ['--checked']
 
-  if (status == 0
-      and (system == 'linux' or runtime != 'chrome')
-      and runtime != 'opera'
-      and runtime != 'ff'
-      and runtime != 'ie'
-      and runtime != 'safari'):
-    status = TestCompiler(runtime, mode, system, option,
-                          test_flags + ['--checked'], is_buildbot)
+  if host_checked: test_flags += ['--host-checked']
+
+  status = TestCompiler(runtime, mode, system, test_flags, is_buildbot)
+  print("ran first");

[ahe, 2012/09/18 13:55:05]

Debug code? Or print something a little more meaningful.

[ricow1, 2012/09/18 14:04:02]

Ups, removed

+
+  # TODO(ricow): We currently have only one browser runtime that runs checked
+  # mode test where this is not reflected by the name, namely dart2js on chrome
+  # linux. We should eliminate this (by splitting this onto two builders -
+  # potentially on the same vm).
+  if (status == 0 and system == 'linux' and runtime == 'chrome'):
+    status = TestCompiler(runtime, mode, system, test_flags + ['--checked'],
+                          is_buildbot)
 
   if runtime != 'd8': CleanUpTemporaryFiles(system, runtime)
   if status != 0: print '@@@STEP_FAILURE@@@'
   return status
 
 if __name__ == '__main__':
   sys.exit(main())