Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 10939016: Add missing space in error message for missing constructor. (Closed)

Created:
8 years, 3 months ago by karlklose
Modified:
8 years, 3 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add missing space in error message for missing constructor. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=12496

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M lib/compiler/implementation/ssa/builder.dart View 1 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
8 years, 3 months ago (2012-09-18 12:46:59 UTC) #1
kasperl
LGTM! http://codereview.chromium.org/10939016/diff/1/lib/compiler/implementation/ssa/builder.dart File lib/compiler/implementation/ssa/builder.dart (right): http://codereview.chromium.org/10939016/diff/1/lib/compiler/implementation/ssa/builder.dart#newcode2831 lib/compiler/implementation/ssa/builder.dart:2831: getTargetName(error, 'constructor '), Nit: Maybe the getTargetName should ...
8 years, 3 months ago (2012-09-18 12:50:16 UTC) #2
karlklose
8 years, 3 months ago (2012-09-18 13:20:17 UTC) #3
Thanks Kasper. I changed getTargetName to insert the space when necessary.

http://codereview.chromium.org/10939016/diff/1/lib/compiler/implementation/ss...
File lib/compiler/implementation/ssa/builder.dart (right):

http://codereview.chromium.org/10939016/diff/1/lib/compiler/implementation/ss...
lib/compiler/implementation/ssa/builder.dart:2831: getTargetName(error,
'constructor '),
On 2012/09/18 12:50:16, kasperl wrote:
> Nit: Maybe the getTargetName should be changed to add a space after the prefix
> if it is provided? You could use the ?prefix test. That way you could get rid
of
> the spaces in prefixes passed to getTargetName.

Done.

Powered by Google App Engine
This is Rietveld 408576698