Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Side by Side Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10939016: Add missing space in error message for missing constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class Interceptors { 5 class Interceptors {
6 Compiler compiler; 6 Compiler compiler;
7 Interceptors(Compiler this.compiler); 7 Interceptors(Compiler this.compiler);
8 8
9 SourceString mapOperatorToMethodName(Operator op) { 9 SourceString mapOperatorToMethodName(Operator op) {
10 String name = op.source.stringValue; 10 String name = op.source.stringValue;
(...skipping 2810 matching lines...) Expand 10 before | Expand all | Expand 10 after
2821 pushInvokeHelper3(helper, receiver, name, arguments); 2821 pushInvokeHelper3(helper, receiver, name, arguments);
2822 } 2822 }
2823 2823
2824 visitNewExpression(NewExpression node) { 2824 visitNewExpression(NewExpression node) {
2825 Element element = elements[node.send]; 2825 Element element = elements[node.send];
2826 if (Elements.isErroneousElement(element)) { 2826 if (Elements.isErroneousElement(element)) {
2827 ErroneousElement error = element; 2827 ErroneousElement error = element;
2828 Message message = error.errorMessage; 2828 Message message = error.errorMessage;
2829 if (message.kind == MessageKind.CANNOT_FIND_CONSTRUCTOR) { 2829 if (message.kind == MessageKind.CANNOT_FIND_CONSTRUCTOR) {
2830 generateThrowNoSuchMethod(node.send, 2830 generateThrowNoSuchMethod(node.send,
2831 getTargetName(error, 'constructor'), 2831 getTargetName(error, 'constructor '),
kasperl 2012/09/18 12:50:16 Nit: Maybe the getTargetName should be changed to
karlklose 2012/09/18 13:20:17 Done.
2832 node.send.arguments); 2832 node.send.arguments);
2833 } else if (message.kind == MessageKind.CANNOT_RESOLVE) { 2833 } else if (message.kind == MessageKind.CANNOT_RESOLVE) {
2834 generateRuntimeError(node.send, message.message); 2834 generateRuntimeError(node.send, message.message);
2835 } else { 2835 } else {
2836 compiler.internalError('unexpected unresolved constructor call', 2836 compiler.internalError('unexpected unresolved constructor call',
2837 node: node); 2837 node: node);
2838 } 2838 }
2839 } else if (node.isConst()) { 2839 } else if (node.isConst()) {
2840 // TODO(karlklose): add type representation 2840 // TODO(karlklose): add type representation
2841 ConstantHandler handler = compiler.constantHandler; 2841 ConstantHandler handler = compiler.constantHandler;
(...skipping 1357 matching lines...) Expand 10 before | Expand all | Expand 10 after
4199 new HSubGraphBlockInformation(elseBranch.graph)); 4199 new HSubGraphBlockInformation(elseBranch.graph));
4200 4200
4201 HBasicBlock conditionStartBlock = conditionBranch.block; 4201 HBasicBlock conditionStartBlock = conditionBranch.block;
4202 conditionStartBlock.setBlockFlow(info, joinBlock); 4202 conditionStartBlock.setBlockFlow(info, joinBlock);
4203 SubGraph conditionGraph = conditionBranch.graph; 4203 SubGraph conditionGraph = conditionBranch.graph;
4204 HIf branch = conditionGraph.end.last; 4204 HIf branch = conditionGraph.end.last;
4205 assert(branch is HIf); 4205 assert(branch is HIf);
4206 branch.blockInformation = conditionStartBlock.blockFlow; 4206 branch.blockInformation = conditionStartBlock.blockFlow;
4207 } 4207 }
4208 } 4208 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698