Issue 1093633004: Add test- and group-level support for skipping tests.

Issue 1093633004: Add test- and group-level support for skipping tests. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add test- and group-level support for skipping tests. See #14 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/09afcf80a4baa26a73dd213d03dd2a97bfcc2012

Patch Set 2 : Code review changes #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+301 lines, -32 lines)			Patch
M	lib/src/backend/declarer.dart	View	1	2 chunks	+21 lines, -4 lines	0 comments	Download
M	lib/src/backend/metadata.dart	View		4 chunks	+32 lines, -9 lines	0 comments	Download
M	lib/src/runner/engine.dart	View		3 chunks	+31 lines, -2 lines	0 comments	Download
M	lib/src/runner/loader.dart	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	lib/src/runner/reporter/compact.dart	View		9 chunks	+40 lines, -7 lines	0 comments	Download
M	lib/src/runner/reporter/no_io_compact.dart	View		6 chunks	+38 lines, -6 lines	0 comments	Download
M	lib/test.dart	View	1	2 chunks	+16 lines, -4 lines	0 comments	Download
M	test/runner/compact_reporter_test.dart	View		1 chunk	+83 lines, -0 lines	0 comments	Download
M	test/runner/engine_test.dart	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

LGTM, other than verbiage https://codereview.chromium.org/1093633004/diff/1/lib/src/backend/declarer.dart File lib/src/backend/declarer.dart (right): https://codereview.chromium.org/1093633004/diff/1/lib/src/backend/declarer.dart#newcode44 lib/src/backend/declarer.dart:44: /// lieu of running the ...

5 years, 8 months ago (2015-04-17 22:53:34 UTC) #2

nweiz

https://codereview.chromium.org/1093633004/diff/1/lib/src/backend/declarer.dart File lib/src/backend/declarer.dart (right): https://codereview.chromium.org/1093633004/diff/1/lib/src/backend/declarer.dart#newcode44 lib/src/backend/declarer.dart:44: /// lieu of running the test. On 2015/04/17 22:53:34, ...

5 years, 8 months ago (2015-04-17 22:56:12 UTC) #4

nweiz

5 years, 8 months ago (2015-04-17 22:56:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
09afcf80a4baa26a73dd213d03dd2a97bfcc2012 (presubmit successful).

Expand Messages | Collapse Messages