Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: lib/src/runner/loader.dart

Issue 1093633004: Add test- and group-level support for skipping tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/engine.dart ('k') | lib/src/runner/reporter/compact.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/loader.dart
diff --git a/lib/src/runner/loader.dart b/lib/src/runner/loader.dart
index 498b14bda176fe1b45019125ebf77b3707966af6..7652165d1eaaaf90c8ecc144f71ed6435928a7e1 100644
--- a/lib/src/runner/loader.dart
+++ b/lib/src/runner/loader.dart
@@ -11,6 +11,7 @@ import 'dart:isolate';
import 'package:analyzer/analyzer.dart';
import 'package:path/path.dart' as p;
+import '../backend/invoker.dart';
import '../backend/metadata.dart';
import '../backend/suite.dart';
import '../backend/test_platform.dart';
@@ -129,6 +130,13 @@ class Loader {
return new Future.value();
}
+ // Don't load a skipped suite.
+ if (metadata.skip) {
+ return new Future.value(new Suite([
+ new LocalTest(path, metadata, () {})
+ ], path: path, platform: platform.name, metadata: metadata));
+ }
+
return new Future.sync(() {
if (_pubServeUrl != null && !p.isWithin('test', path)) {
throw new LoadException(path,
« no previous file with comments | « lib/src/runner/engine.dart ('k') | lib/src/runner/reporter/compact.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698