dart2js: add type arguments to constructor in case the class needs rti.

dart2js: add type arguments to constructor in case the class needs rti.

R=herhut@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45277

Reverted: https://code.google.com/p/dart/source/detail?r=45281

Committed: https://code.google.com/p/dart/source/detail?r=45485

Reverted: https://code.google.com/p/dart/source/detail?r=45487

[zarah, 2015-04-20 09:53:26]

zarah@google.com changed reviewers:
+ herhut@google.com

[herhut, 2015-04-20 10:24:29]

lgtm w/ comments

https://codereview.chromium.org/1092263002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/1092263002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:25: if (typeInfo)
this.\$builtinTypeInfo = typeInfo;
Why not set this unconditionally? Then the instances with and without typeInfo
will get the same map and the value is still undefined if no typeinfo was
provided....

https://codereview.chromium.org/1092263002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart
(right):

https://codereview.chromium.org/1092263002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart:236: body
+= "if (typeInfo) this.\$builtinTypeInfo = typeInfo;\\n";
Same here...

[zarah, 2015-04-20 11:00:56]

Committed patchset #1 (id:1) manually as 45277 (presubmit successful).

[zarah, 2015-04-20 12:34:50]

https://codereview.chromium.org/1092263002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/1092263002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:25: if (typeInfo)
this.\$builtinTypeInfo = typeInfo;
On 2015/04/20 10:24:29, herhut wrote:
> Why not set this unconditionally? Then the instances with and without typeInfo
> will get the same map and the value is still undefined if no typeinfo was
> provided....

There is code depending on whether or not that property is there, so, as
discussed, leaving it for now and added a todo.

https://codereview.chromium.org/1092263002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart
(right):

https://codereview.chromium.org/1092263002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart:236: body
+= "if (typeInfo) this.\$builtinTypeInfo = typeInfo;\\n";
On 2015/04/20 10:24:29, herhut wrote:
> Same here...

See reply to the other comment.

[zarah, 2015-05-04 08:51:59]

Patchset #4 (id:60001) has been deleted

[zarah, 2015-05-04 08:54:29]

PTAL

[herhut, 2015-05-04 08:59:13]

lgtm

[zarah, 2015-05-04 09:38:09]

Committed patchset #4 (id:80001) manually as 45485 (presubmit successful).