Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

Issue 1092263002: dart2js: add type arguments to constructor in case the class needs rti. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 // TODO(ahe): Share these with js_helper.dart. 7 // TODO(ahe): Share these with js_helper.dart.
8 const FUNCTION_INDEX = 0; 8 const FUNCTION_INDEX = 0;
9 const NAME_INDEX = 1; 9 const NAME_INDEX = 1;
10 const CALL_NAME_INDEX = 2; 10 const CALL_NAME_INDEX = 2;
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 226
227 for (var i = 0; i < fields.length; i++) { 227 for (var i = 0; i < fields.length; i++) {
228 if(i != 0) str += ", "; 228 if(i != 0) str += ", ";
229 229
230 var field = generateAccessor(fields[i], accessors, name); 230 var field = generateAccessor(fields[i], accessors, name);
231 if (#hasIsolateSupport) { fieldNames += "'" + field + "',"; } 231 if (#hasIsolateSupport) { fieldNames += "'" + field + "',"; }
232 var parameter = "p_" + field; 232 var parameter = "p_" + field;
233 str += parameter; 233 str += parameter;
234 body += ("this." + field + " = " + parameter + ";\\n"); 234 body += ("this." + field + " = " + parameter + ";\\n");
235 } 235 }
236 body += "if (typeInfo) this.\$builtinTypeInfo = typeInfo;\\n";
herhut 2015/04/20 10:24:29 Same here...
zarah 2015/04/20 12:34:50 See reply to the other comment.
236 if (supportsDirectProtoAccess) { 237 if (supportsDirectProtoAccess) {
237 body += "this." + #deferredActionString + "();"; 238 body += "this." + #deferredActionString + "();";
238 } 239 }
239 str += ") {\\n" + body + "}\\n"; 240
241 if (fields.length > 0) str += ",";
242 str += "typeInfo) {\\n" + body + "}\\n";
240 str += name + ".builtin\$cls=\\"" + name + "\\";\\n"; 243 str += name + ".builtin\$cls=\\"" + name + "\\";\\n";
241 str += "\$desc=\$collectedClasses." + name + "[1];\\n"; 244 str += "\$desc=\$collectedClasses." + name + "[1];\\n";
242 str += name + ".prototype = \$desc;\\n"; 245 str += name + ".prototype = \$desc;\\n";
243 if (typeof defineClass.name != "string") { 246 if (typeof defineClass.name != "string") {
244 str += name + ".name=\\"" + name + "\\";\\n"; 247 str += name + ".name=\\"" + name + "\\";\\n";
245 } 248 }
246 if (#hasIsolateSupport) { 249 if (#hasIsolateSupport) {
247 str += name + "." + #fieldNamesProperty + "=[" + fieldNames 250 str += name + "." + #fieldNamesProperty + "=[" + fieldNames
248 + "];\\n"; 251 + "];\\n";
249 } 252 }
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
843 (function() { 846 (function() {
844 var result = $array[$index]; 847 var result = $array[$index];
845 if ($check) { 848 if ($check) {
846 throw new Error( 849 throw new Error(
847 name + ": expected value of type \'$type\' at index " + ($index) + 850 name + ": expected value of type \'$type\' at index " + ($index) +
848 " but got " + (typeof result)); 851 " but got " + (typeof result));
849 } 852 }
850 return result; 853 return result;
851 })()'''; 854 })()''';
852 } 855 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698