Issue 10919323: - Fix the implementation of Random.nextBool() and add test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10919323: - Fix the implementation of Random.nextBool() and add test. (Closed)

Created:
8 years, 3 months ago by Ivan Posva

Modified:
8 years, 3 months ago

Reviewers:
kasperl, siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Fix the implementation of Random.nextBool() and add test. Committed: https://code.google.com/p/dart/source/detail?r=12458

Patch Set 1 #

Total comments: 3

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -3 lines)			Patch
	M	runtime/lib/math_patch.dart	View		1 chunk	+3 lines, -3 lines	1 comment	Download
	A	tests/lib/math/coin_test.dart	View		1 chunk	+30 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://chromiumcodereview.appspot.com/10919323/diff/1/runtime/lib/math_patch.dart File runtime/lib/math_patch.dart (right): https://chromiumcodereview.appspot.com/10919323/diff/1/runtime/lib/math_patch.dart#newcode72 runtime/lib/math_patch.dart:72: return nextInt(2) == 0; This is the only functional ...

8 years, 3 months ago (2012-09-17 21:22:13 UTC) #1

kasperl

https://chromiumcodereview.appspot.com/10919323/diff/1/tests/lib/math/coin_test.dart File tests/lib/math/coin_test.dart (right): https://chromiumcodereview.appspot.com/10919323/diff/1/tests/lib/math/coin_test.dart#newcode5 tests/lib/math/coin_test.dart:5: // Test that the default PRNG does converge towards ...

8 years, 3 months ago (2012-09-18 06:24:30 UTC) #3

Ivan Posva

8 years, 3 months ago (2012-09-18 12:49:16 UTC) #4

https://codereview.chromium.org/10919323/diff/1/tests/lib/math/coin_test.dart
File tests/lib/math/coin_test.dart (right):

https://codereview.chromium.org/10919323/diff/1/tests/lib/math/coin_test.dart...
tests/lib/math/coin_test.dart:5: // Test that the default PRNG does converge
towards Pi when doing a Monte Carlo
On 2012/09/18 06:24:30, kasperl wrote:
> Update comment?

https://codereview.chromium.org/10948008

Expand Messages | Collapse Messages