- Fix the implementation of Random.nextBool() and add test.

runtime/lib/math_patch.dart

Index: runtime/lib/math_patch.dart
===================================================================
--- runtime/lib/math_patch.dart	(revision 12454)
+++ runtime/lib/math_patch.dart	(working copy)
@@ -60,16 +60,16 @@
     do {
       rnd32 = _nextInt32();
       result = rnd32 % max;
-    } while (rnd32 - result + max >= _POW2_32);
+    } while ((rnd32 - result + max) >= _POW2_32);
     return result;
   }
 
   double nextDouble() {
-    return ((nextInt(1 << (26)) << 27) + nextInt(1 << 27)) / _POW2_53_D;
+    return ((nextInt(1 << 26) << 27) + nextInt(1 << 27)) / _POW2_53_D;
   }
 
   bool nextBool() {
-    return nextInt(1) == 0;
+    return nextInt(2) == 0;

[Ivan Posva, 2012/09/17 21:22:13]

This is the only functional change!

   }
 
   // Constants used by the algorithm or masking.