Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1091883002: More gracefully handle browser errors. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : Fix analysis warnings #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -44 lines) Patch
M CHANGELOG.md View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M lib/src/runner/browser/chrome.dart View 1 2 4 chunks +18 lines, -11 lines 0 comments Download
M lib/src/runner/browser/content_shell.dart View 1 2 2 chunks +17 lines, -3 lines 0 comments Download
M lib/src/runner/browser/dartium.dart View 1 2 4 chunks +18 lines, -11 lines 0 comments Download
M lib/src/runner/browser/firefox.dart View 1 2 3 4 chunks +18 lines, -12 lines 0 comments Download
M lib/src/runner/browser/phantom_js.dart View 1 2 2 chunks +17 lines, -3 lines 0 comments Download
M lib/src/runner/browser/safari.dart View 1 2 2 chunks +16 lines, -3 lines 0 comments Download
M lib/src/runner/browser/server.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
nweiz
5 years, 8 months ago (2015-04-16 22:33:02 UTC) #1
kevmoo
On 2015/04/16 22:33:02, nweiz wrote: Rebase please? I got a conflict w/ the CHANGELOG. Also: ...
5 years, 8 months ago (2015-04-16 22:44:30 UTC) #2
nweiz
On 2015/04/16 22:44:30, kevmoo wrote: > On 2015/04/16 22:33:02, nweiz wrote: > > Rebase please? ...
5 years, 8 months ago (2015-04-16 22:57:12 UTC) #3
kevmoo
Looks like you're missing imports across all of the browser runners
5 years, 8 months ago (2015-04-17 00:11:19 UTC) #4
nweiz
On 2015/04/17 00:11:19, kevmoo wrote: > Looks like you're missing imports across all of the ...
5 years, 8 months ago (2015-04-17 22:09:44 UTC) #5
kevmoo
lgtm
5 years, 8 months ago (2015-04-17 22:14:39 UTC) #6
nweiz
5 years, 8 months ago (2015-04-17 22:16:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
daeedab216e1b4505c1f43e4feea546799672d4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698