Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: lib/src/runner/browser/server.dart

Issue 1091883002: More gracefully handle browser errors. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: merge Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/safari.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/server.dart
diff --git a/lib/src/runner/browser/server.dart b/lib/src/runner/browser/server.dart
index fb0e55abddf6f16b6d0569b6715785ac54854bd8..17862ebcb7fa4b844b4d49782f8f2a60442c7361 100644
--- a/lib/src/runner/browser/server.dart
+++ b/lib/src/runner/browser/server.dart
@@ -266,7 +266,7 @@ void main() {
// TODO(nweiz): Don't start the browser until all the suites are compiled.
return _browserManagerFor(browser).then((browserManager) {
- if (_closed) return null;
+ if (_closed || browserManager == null) return null;
return browserManager.loadSuite(path, suiteUrl, metadata);
}).then((suite) {
if (_closed) return null;
« no previous file with comments | « lib/src/runner/browser/safari.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698