Issue 10914318: Issue 5148. Error on abstract method in concrete class needs to be a warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10914318: Issue 5148. Error on abstract method in concrete class needs to be a warning (Closed)

Created:
8 years, 3 months ago by scheglov

Modified:
8 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 5148. Error on abstract method in concrete class needs to be a warning http://code.google.com/p/dart/issues/detail?id=5148 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12445

Patch Set 1 #

Patch Set 2 : Update status files #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -38 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	1	1 chunk	+8 lines, -7 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	1	2 chunks	+2 lines, -1 line	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1	3 chunks	+8 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM, though I expected some of the tests that are currently failing would start to ...

8 years, 3 months ago (2012-09-17 14:59:44 UTC) #2

Brian Wilkerson

8 years, 3 months ago (2012-09-17 16:42:32 UTC) #4

LGTM

https://codereview.chromium.org/10914318/diff/4001/compiler/java/com/google/d...
File compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java
(right):

https://codereview.chromium.org/10914318/diff/4001/compiler/java/com/google/d...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:186:
STATIC_METHOD_MUST_HAVE_BODY("Static Method must have a body"),
nit: "Method" --> "method"

Expand Messages | Collapse Messages