compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java - Issue 10914318: Issue 5148. Error on abstract method in concrete class needs to be a warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

Issue 10914318: Issue 5148. Error on abstract method in concrete class needs to be a warning (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update status files Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Resolver.java ('k') | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java b/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

index 4e01b7a8beb135b070f2e3dbef4c37120cb4cc41..f9ced60a6b601f7380f4747583328e60a44ac2d6 100644

--- a/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

+++ b/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

@@ -152,7 +152,7 @@ public enum ResolverErrorCode implements ErrorCode {

CONSTRUCTOR_WITH_NAME_OF_MEMBER(

ErrorSeverity.WARNING,

"Constructor cannot have the same name as the name of a member declared in the enclosing class"),

- METHOD_MUST_HAVE_BODY("Method must have a body in a non-abstract class"),

+ METHOD_MUST_HAVE_BODY(ErrorSeverity.WARNING, "Method must have a body in a non-abstract class"),

NAMED_PARAMETERS_CANNOT_START_WITH_UNDER("Named parameters cannot start with an '_' character"),

NEW_EXPRESSION_CANT_USE_TYPE_VAR("New expression cannot be invoked on type variable"),

NEW_EXPRESSION_NOT_CONSTRUCTOR(

@@ -183,6 +183,7 @@ public enum ResolverErrorCode implements ErrorCode {

"Target of constant redirecting factory constructor also should be constant"),

RETHROW_NOT_IN_CATCH("Re-throw not in a catch block"),

STATIC_FINAL_REQUIRES_VALUE("Static final fields must have an initial value"),

+ STATIC_METHOD_MUST_HAVE_BODY("Static Method must have a body"),

Brian Wilkerson 2012/09/17 16:42:32 nit: "Method" --> "method"

SUPER_IN_FACTORY_CONSTRUCTOR("Cannot use 'super' in a factory constructor"),

SUPER_IN_STATIC_METHOD("Cannot use 'super' in a static method"),

SUPER_OUTSIDE_OF_METHOD("Cannot use 'super' outside of a method"),