Issue 10914286: Remove Object.dynamic.

Issue 10914286: Remove Object.dynamic. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove Object.dynamic. Committed: https://code.google.com/p/dart/source/detail?r=12432

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address review smells. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -87 lines)			Patch
M	lib/compiler/implementation/lib/interceptors.dart	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+21 lines, -12 lines	0 comments	Download
M	lib/core/object.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	samples/maps/directions.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	samples/ui_lib/util/CollectionUtils.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-compiler.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/html/instance_of_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/language/number_syntax_test.dart	View		1 chunk	+0 lines, -24 lines	0 comments	Download
D	tests/language/object_dynamic_method_test.dart	View		1 chunk	+0 lines, -33 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	utils/template/htmltree.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. It's interesting that my gut reaction to most of these changes is that the ...

8 years, 3 months ago (2012-09-14 07:56:33 UTC) #2

Lasse Reichstein Nielsen

8 years, 3 months ago (2012-09-17 11:58:06 UTC) #3

https://chromiumcodereview.appspot.com/10914286/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10914286/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:2401: if (link.isEmpty() ||
link.isEmpty()) {
This seems wrong!

https://chromiumcodereview.appspot.com/10914286/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:2410: if (literal is !StringNode ||
(literal as Dynamic).isInterpolation) {
Still, it sucks. I'll change this.

https://chromiumcodereview.appspot.com/10914286/diff/1/samples/maps/direction...
File samples/maps/directions.dart (right):

https://chromiumcodereview.appspot.com/10914286/diff/1/samples/maps/direction...
samples/maps/directions.dart:49: (map.controls[ControlPosition.TOP] as
Dynamic).push('#control');
You think? :)
Sadly, I have no idea what is going on here, or what type the expression really
has.

https://chromiumcodereview.appspot.com/10914286/diff/1/samples/ui_lib/util/Co...
File samples/ui_lib/util/CollectionUtils.dart (right):

https://chromiumcodereview.appspot.com/10914286/diff/1/samples/ui_lib/util/Co...
samples/ui_lib/util/CollectionUtils.dart:49: List result = new List(source is
List ? (source as Dynamic).length : null);
Much. And it's obvious what to do, so I'll make the cast to "as List".

Expand Messages | Collapse Messages