Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 10914286: Remove Object.dynamic. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review smells. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/object_dynamic_method_test.dart ('k') | utils/template/htmltree.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index e349dfc64f83c1a4d696db3ff60f53accdd116a7..95228efe6cb3e36829671340f07ddb509e54dd0b 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -316,7 +316,7 @@ class BrowserTestOutputImpl extends TestOutputImpl {
line.contains('Failed to run command. return code=1')) {
// If we get the X server error, or DRT crashes with a core dump, retry
// the test.
- if (testCase.dynamic.numRetries > 0) {
+ if ((testCase as Dynamic).numRetries > 0) {
requestRetry = true;
}
return true;
@@ -551,16 +551,16 @@ class RunningProcess {
}
if (allowRetries && testCase.usesWebDriver
&& testCase.output.unexpectedOutput
- && testCase.dynamic.numRetries > 0) {
+ && (testCase as Dynamic).numRetries > 0) {
// Selenium tests can be flaky. Try rerunning.
testCase.output.requestRetry = true;
}
if (testCase.output.requestRetry) {
testCase.output.requestRetry = false;
this.timedOut = false;
- testCase.dynamic.numRetries--;
+ (testCase as Dynamic).numRetries--;
print("Potential flake. Re-running ${testCase.displayName} "
- "(${testCase.dynamic.numRetries} attempt(s) remains)");
+ "(${(testCase as Dynamic).numRetries} attempt(s) remains)");
this.start();
} else {
testCase.completed();
« no previous file with comments | « tests/language/object_dynamic_method_test.dart ('k') | utils/template/htmltree.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698