Move parseInt parseDouble to int/double classes as a static method.

Move parseInt parseDouble to int/double classes as a static method.

Remove math dependency from core/coreimpl in dart2js.
The existing Math.parseInt and Math.parseDouble are kept *for now*, but
simply redirect to the static methods.
They will be removed in time (when library code is ready for it).

Committed: https://code.google.com/p/dart/source/detail?r=12417

[Lasse Reichstein Nielsen, 2012-09-14 11:10:01]

https://codereview.chromium.org/10913271/diff/1/runtime/lib/double_patch.dart
File runtime/lib/double_patch.dart (right):

https://codereview.chromium.org/10913271/diff/1/runtime/lib/double_patch.dart...
runtime/lib/double_patch.dart:10: MathNatives.parseDouble(string);
You might want to move the parse function to something else than MathNatives,
but I don't know if you want to introduce a DoubleNatives namespace or something
else, so I'll leave that to a proper VM developer.

[hausner, 2012-09-14 15:40:54]

LGTM w/comments

https://codereview.chromium.org/10913271/diff/1/runtime/lib/double_patch.dart
File runtime/lib/double_patch.dart (right):

https://codereview.chromium.org/10913271/diff/1/runtime/lib/double_patch.dart...
runtime/lib/double_patch.dart:10: MathNatives.parseDouble(string);
Or how about calling the native function directly from here instead of going
through another indirection?

On 2012/09/14 11:10:01, Lasse Reichstein Nielsen wrote:
> You might want to move the parse function to something else than MathNatives,
> but I don't know if you want to introduce a DoubleNatives namespace or
something
> else, so I'll leave that to a proper VM developer.

https://codereview.chromium.org/10913271/diff/1/runtime/lib/integers_patch.dart
File runtime/lib/integers_patch.dart (right):

https://codereview.chromium.org/10913271/diff/1/runtime/lib/integers_patch.da...
runtime/lib/integers_patch.dart:9: /* patch */ static int parse(String string)
=> MathNatives.parseInt(string);
If patch functions can be natives, I would call the corresponding native
function directly from here.

[Lasse Reichstein Nielsen, 2012-09-17 07:20:34]

The int.parse and double.parse functions are now native.
It still calls the native "MathNatives_parseInt". That will probably need
renaming, but I can't say whether it should be "int_parse" or "Integer_parse".
Leaving as-is for now.

[hausner, 2012-09-17 15:27:51]

Thanks :)