runtime/lib/double_patch.dart - Issue 10913271: Move parseInt parseDouble to int/double classes as a static method.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/double_patch.dart

Issue 10913271: Move parseInt parseDouble to int/double classes as a static method. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4

5 // Dart core library.	4 // Dart core library.

6	5

7 class bool {	6 // VM implementation of double.

8 factory bool._uninstantiable() {	7

9 throw const UnsupportedOperationException(	8 patch class double {

10 "class bool cannot be instantiated");	9 /* patch */ static double parse(String string) =>

11 }	10 MathNatives.parseDouble(string);
	Lasse Reichstein Nielsen 2012/09/14 11:10:01 You might want to move the parse function to somet You might want to move the parse function to something else than MathNatives, but I don't know if you want to introduce a DoubleNatives namespace or something else, so I'll leave that to a proper VM developer. hausner 2012/09/14 15:40:59 Or how about calling the native function directly Or how about calling the native function directly from here instead of going through another indirection? On 2012/09/14 11:10:01, Lasse Reichstein Nielsen wrote: Show quoted text > You might want to move the parse function to something else than MathNatives, > but I don't know if you want to introduce a DoubleNatives namespace or something > else, so I'll leave that to a proper VM developer.
12 }	11 }

OLD	NEW

« no previous file with comments | « pkg/unittest/interactive_html_config.dart ('k') | runtime/lib/integers_patch.dart » ('j') | runtime/lib/integers_patch.dart » ('J')