Issue 10911312: Properly process constructs like Class.getter++ where there is no setter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10911312: Properly process constructs like Class.getter++ where there is no setter. (Closed)

Created:
8 years, 3 months ago by Anton Muhin

Modified:
8 years, 3 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Properly process constructs like Class.getter++ where there is no setter. R=smok@google.com BUG=5178 Committed: https://code.google.com/p/dart/source/detail?r=12436

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
	M	lib/compiler/implementation/dart_backend/placeholder_collector.dart	View	1	2 chunks	+12 lines, -7 lines	0 comments	Download
	M	tests/language/language.status	View	1	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roman

lgtm https://codereview.chromium.org/10911312/diff/1/lib/compiler/implementation/dart_backend/placeholder_collector.dart File lib/compiler/implementation/dart_backend/placeholder_collector.dart (left): https://codereview.chromium.org/10911312/diff/1/lib/compiler/implementation/dart_backend/placeholder_collector.dart#oldcode381 lib/compiler/implementation/dart_backend/placeholder_collector.dart:381: assert(element is VariableElement || element.isSetter()); Maybe just add ...

8 years, 3 months ago (2012-09-17 10:19:39 UTC) #2

Anton Muhin

8 years, 3 months ago (2012-09-17 14:13:06 UTC) #3

https://codereview.chromium.org/10911312/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart (left):

https://codereview.chromium.org/10911312/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:381:
assert(element is VariableElement || element.isSetter());
On 2012/09/17 10:19:39, Roman wrote:
> Maybe just add element.isGetter() to the assert? It is useful at least as a
> documentational thing for code reader.

Done.

Expand Messages | Collapse Messages

Issue 10911312: Properly process constructs like Class.getter++ where there is no setter. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages