Properly process constructs like Class.getter++ where there is no setter.

lib/compiler/implementation/dart_backend/placeholder_collector.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class LocalPlaceholder implements Hashable {
   final String identifier;
   final Set<Node> nodes;
   LocalPlaceholder(this.identifier) : nodes = new Set<Node>();
   int hashCode() => identifier.hashCode();
   String toString() =>
@@ skipping 357 matching lines @@
   visit(Node node) => (node === null) ? null : node.accept(this);
 
   visitNode(Node node) { node.visitChildren(this); }  // We must go deeper.
 
   visitSend(Send send) {
     new SendVisitor(this, treeElements).visitSend(send);
     send.visitChildren(this);
   }
 
   visitSendSet(SendSet send) {
-    final element = treeElements[send];
-    if (!Elements.isUnresolved(element)) {
+    Element element = treeElements[send];
+    if (Elements.isErroneousElement(element)) {
+      // Complicated case: constructs like receiver.selector++ can resolve
+      // to ErroneousElement.  Fortunately, receiver.selector still
+      // can be resoved via treeElements[send.selector], that's all
+      // that is needed to rename the construct properly.
+      element = treeElements[send.selector];
+    }
+    if (element === null) {
+      if (send.receiver !== null) tryMakeMemberPlaceholder(send.selector);
+    } else if (!element.isErroneous()) {
       if (Elements.isStaticOrTopLevel(element)) {
-        assert(element is VariableElement || element.isSetter());

[Roman, 2012/09/17 10:19:39]

Maybe just add element.isGetter() to the assert? It is useful at least as a
documentational thing for code reader.

[Anton Muhin, 2012/09/17 14:13:06]

Done.

         makeElementPlaceholder(send.selector, element);
       } else {
         assert(send.selector is Identifier);
         if (Elements.isInstanceField(element)) {
           tryMakeMemberPlaceholder(send.selector);
         } else {
           tryMakeLocalPlaceholder(element, send.selector);
         }
       }
-    } else {
-      if (send.receiver !== null) {
-        tryMakeMemberPlaceholder(send.selector);
-      }
     }
     send.visitChildren(this);
   }
 
   visitIdentifier(Identifier identifier) {
     if (identifier.source.isPrivate()) makePrivateIdentifier(identifier);
   }
 
   static bool isPlainTypeName(TypeAnnotation typeAnnotation) {
     if (typeAnnotation.typeName is !Identifier) return false;
@@ skipping 174 matching lines @@
 
   visitBlock(Block node) {
     for (Node statement in node.statements.nodes) {
       if (statement is VariableDefinitions) {
         makeVarDeclarationTypePlaceholder(statement);
       }
     }
     node.visitChildren(this);
   }
 }