Issue 10910252: Improve register usage for StoreInstanceField.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10910252: Improve register usage for StoreInstanceField. (Closed)

Created:
8 years, 3 months ago by Florian Schneider

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve register usage for StoreInstanceField and StoreIndexed. No need for a temp if we don't emit a write barrier and use a immediate operand for the value if available. Committed: https://code.google.com/p/dart/source/detail?r=12310

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment and improved StoreIndexed as well. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -24 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	3 chunks	+17 lines, -9 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	3 chunks	+15 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/10910252/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/10910252/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode956 runtime/vm/intermediate_language_ia32.cc:956: summary->set_in(1, (value()->NeedsStoreBuffer() && emit_store_barrier()) nice catch. maybe move ...

8 years, 3 months ago (2012-09-13 10:35:43 UTC) #2

Florian Schneider

8 years, 3 months ago (2012-09-13 10:46:07 UTC) #3

https://codereview.chromium.org/10910252/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/10910252/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_ia32.cc:956: summary->set_in(1,
(value()->NeedsStoreBuffer() && emit_store_barrier())
On 2012/09/13 10:35:43, Vyacheslav Egorov (Google) wrote:
> nice catch.
> 
> maybe move this a && b to some helper method?

Done.

Expand Messages | Collapse Messages