Issue 10907248: Don't use TEMP_FAILURE_RETRY macro with inet_addr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907248: Don't use TEMP_FAILURE_RETRY macro with inet_addr (Closed)

Created:
8 years, 3 months ago by jackpal

Modified:
8 years, 3 months ago

Reviewers:
Mads Ager (google), Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't use TEMP_FAILURE_RETRY macro with inet_addr inet_addr is not a syscall, therefore it should not be used with the TEMP_FAILURE_RETRY macro. This fixes a warning in the Android build. Committed: https://code.google.com/p/dart/source/detail?r=12447

Patch Set 1 #

Patch Set 2 : Modify change list to remove description of potential infinite loop. Not sure it is really possible. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -8 lines)			Patch
M	runtime/bin/socket_android.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	runtime/bin/socket_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_macos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jackpal

The Android libc maintainer pointed out that inet_addr is not a syscall, and so it ...

8 years, 3 months ago (2012-09-15 00:49:52 UTC) #1

LGTM, thanks!

Expand Messages | Collapse Messages