Issue 1089953004: VM: Fix potential bug in x64 inline cache stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1089953004: VM: Fix potential bug in x64 inline cache stub. (Closed)

Created:
5 years, 8 months ago by Florian Schneider

Modified:
5 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Fix potential bug in x64 inline cache stub. A frame entered with EnterStubFrame, must be left with LeaveStubFrame. It did not cause a crash since the inline cache stubs don't load a new pool pointer, but leave PP unchanged and use the callers pp. I checked other platforms - they already use LeaveStubFrame in the right places. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45345

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/stub_code_x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

5 years, 8 months ago (2015-04-22 13:11:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r45345 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages