Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Side by Side Diff: runtime/vm/stub_code_x64.cc

Issue 1089953004: VM: Fix potential bug in x64 inline cache stub. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1472 matching lines...) Expand 10 before | Expand all | Expand 10 after
1483 __ pushq(R9); 1483 __ pushq(R9);
1484 } 1484 }
1485 __ pushq(R8); 1485 __ pushq(R8);
1486 __ call(RCX); 1486 __ call(RCX);
1487 1487
1488 Label done; 1488 Label done;
1489 __ movq(RDX, RAX); 1489 __ movq(RDX, RAX);
1490 __ movq(RBX, Address(RBP, kFirstLocalSlotFromFp * kWordSize)); 1490 __ movq(RBX, Address(RBP, kFirstLocalSlotFromFp * kWordSize));
1491 __ UpdateRangeFeedback(RDX, 2, RBX, RCX, &done); 1491 __ UpdateRangeFeedback(RDX, 2, RBX, RCX, &done);
1492 __ Bind(&done); 1492 __ Bind(&done);
1493 __ LeaveFrame(); 1493 __ LeaveStubFrame();
1494 __ ret(); 1494 __ ret();
1495 } else { 1495 } else {
1496 __ jmp(RCX); 1496 __ jmp(RCX);
1497 } 1497 }
1498 1498
1499 __ Bind(&stepping); 1499 __ Bind(&stepping);
1500 __ EnterStubFrame(); 1500 __ EnterStubFrame();
1501 __ pushq(RBX); 1501 __ pushq(RBX);
1502 __ CallRuntime(kSingleStepHandlerRuntimeEntry, 0); 1502 __ CallRuntime(kSingleStepHandlerRuntimeEntry, 0);
1503 __ popq(RBX); 1503 __ popq(RBX);
(...skipping 595 matching lines...) Expand 10 before | Expand all | Expand 10 after
2099 2099
2100 __ movq(left, Address(RSP, 2 * kWordSize)); 2100 __ movq(left, Address(RSP, 2 * kWordSize));
2101 __ movq(right, Address(RSP, 1 * kWordSize)); 2101 __ movq(right, Address(RSP, 1 * kWordSize));
2102 GenerateIdenticalWithNumberCheckStub(assembler, left, right); 2102 GenerateIdenticalWithNumberCheckStub(assembler, left, right);
2103 __ ret(); 2103 __ ret();
2104 } 2104 }
2105 2105
2106 } // namespace dart 2106 } // namespace dart
2107 2107
2108 #endif // defined TARGET_ARCH_X64 2108 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698