Issue 1088433004: Add StackTrace.fromString constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1088433004: Add StackTrace.fromString constructor. (Closed)

Created:
5 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Add StackTrace.fromString constructor. Remove _RemoteStackTrace from dart:isolate and use the new version instead. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45088

Patch Set 1 #

Patch Set 2 : Add suggestion to use StackTrace.fromString in Isolate.addErrorListener. #

Patch Set 3 : Add test. #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -10 lines)			Patch
M	sdk/lib/core/stacktrace.dart	View		2 chunks	+21 lines, -0 lines	0 comments	Download
M	sdk/lib/isolate/isolate.dart	View	1	2 chunks	+2 lines, -7 lines	0 comments	Download
A	tests/corelib/stacktrace_fromstring_test.dart	View	1 2	1 chunk	+41 lines, -0 lines	0 comments	Download
M	tests/language/custom_await_stack_trace_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

Committed patchset #3 (id:40001) manually as 45088 (presubmit successful).

5 years, 8 months ago (2015-04-13 09:17:23 UTC) #4

kevmoo

5 years, 6 months ago (2015-06-23 20:53:50 UTC) #5

Message was sent while issue was closed.

On 2015/04/13 09:17:23, Lasse Reichstein Nielsen wrote:
> Committed patchset #3 (id:40001) manually as 45088 (presubmit successful).

Please update CHANGELOG.md when making API changes

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages